Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT flag
To:     Christoph Hellwig <hch@lst.de>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tomasz Figa <tfiga@chromium.org>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200911030758.73745-1-sergey.senozhatsky@gmail.com>
 <20200911100919.GA1945@lst.de>
From:   Hans Verkuil <hverkuil-cisco@xs4all.nl>
Message-ID: <262a3acd-9070-8992-f13f-1f02bfe18eb8@xs4all.nl>
Date:   Fri, 11 Sep 2020 12:37:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200911100919.GA1945@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/09/2020 12:09, Christoph Hellwig wrote:
> Btw, the subject should probably read something like:
> 
> media/v4l2: remove the V4L2_FLAG_MEMORY_NON_CONSISTENT flag
> 
> I messed up the spelling because I copied it from the documentation.
> 


I'll take care of that. I also discovered that one call to vb2_core_reqbufs()
wasn't updated (in drivers/media/dvb-core/dvb_vb2.c). I've fixed that as well.

All my regression tests passed, so I plan to post a PR for 5.9 reverting this
feature soon.

Many thanks to everyone for 1) discovering this problem and 2) creating a patch
to revert this.

Regards,

	Hans