Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 12:00:18 +0100
From:   Mark Brown <broonie@kernel.org>
To:     kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
Cc:     Ashish Kumar <ashish.kumar@nxp.com>,
        Yogesh Gaur <yogeshgaur.83@gmail.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Varun Sethi <V.Sethi@nxp.com>,
        Arokia Samy <arokia.samy@nxp.com>,
        Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
        Paul Yang <Paul.Yang@arm.com>
Subject: Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
Message-ID: <20200911110018.GD4895@sirena.org.uk>
References: <20200911082806.115-1-kuldip.dwivedi@puresoftware.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+"
Content-Disposition: inline
In-Reply-To: <20200911082806.115-1-kuldip.dwivedi@puresoftware.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ZwgA9U+XZDXt4+m+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 11, 2020 at 01:58:06PM +0530, kuldip dwivedi wrote:

>  	/* find the resources - configuration register address space */
>  	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "fspi_base");
> +#ifdef CONFIG_ACPI
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +#endif

This is buggy, it is equivalent to just removing the name based lookup
since we'll do the name based lookup then unconditionally overwrite the
results with an index based lookup.

--ZwgA9U+XZDXt4+m+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9bWMEACgkQJNaLcl1U
h9AP3Qf9F5MBd+/yYgkOXPnvYDAXBr1i2AuuQMddO6Y8ZlWJ72PKuPXguf51tDc4
Q/6JW2iszIFliNxNRseaU6yee4gq2TaJiXLIw4TrM1KKbQu8k0RLYn8rBWBzP4vE
amVyHom7JC0haZNNR0xNRHxRv/7QJ/O24uG/7wDPKG6SMT5GuNABquh8AzSwDejM
rAEpxa+/flzZ8RaM/WvsIEo0C4okKla+MHjN5ozo3J6Y9/NnTYrzOy12Vy1qORuZ
7E6JsUEBEuWuy+IIFBhM3nbspLOxXwUBZZbo3uc6AEqpQwE+es/fOD7IlFCChDgv
9ndAqagEqrJBbrOGz0+rk+P0PS4Rfw==
=vHAM
-----END PGP SIGNATURE-----

--ZwgA9U+XZDXt4+m+--