Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Cc:     mtk.manpages@gmail.com, linux-man@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/24] pthread_setname_np.3: ffix
To:     Alejandro Colomar <colomar.6.4.3@gmail.com>
References: <20200910211344.3562-1-colomar.6.4.3@gmail.com>
 <20200910211344.3562-20-colomar.6.4.3@gmail.com>
 <e651f418-ada8-19e1-359e-9906994108eb@gmail.com>
 <2c2150bc-d4df-e821-1717-6450540b6c71@gmail.com>
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Message-ID: <b6902713-54f0-3d9f-2c02-92eb94b278a6@gmail.com>
Date:   Fri, 11 Sep 2020 13:12:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <2c2150bc-d4df-e821-1717-6450540b6c71@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Alex,

On 9/11/20 10:32 AM, Alejandro Colomar wrote:
> Hi Michael,
> 
> The indentation in the original code was a bit weird (specifically, the 
> 'do {' part had one more indentation level than the closing '} while'), 
> so I simply chose something nice.  See the original page, and if you 
> think it's ok keep it, else find something nice :)

Sorry -- I was being a bit slow. Now I see what you mean.
I've fixed it, but in a different way.

Thanks,

Michael

> On 2020-09-11 09:58, Michael Kerrisk (man-pages) wrote:
>> Hi Alex,
>>
>> On 9/10/20 11:13 PM, Alejandro Colomar wrote:
>>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@gmail.com>
>>> ---
>>>   man3/pthread_setname_np.3 | 5 +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> What's the rationale for this patch?
>>
>> Thanks,
>>
>> Michael
>>>
>>> diff --git a/man3/pthread_setname_np.3 b/man3/pthread_setname_np.3
>>> index b206f66c0..4dc4960cd 100644
>>> --- a/man3/pthread_setname_np.3
>>> +++ b/man3/pthread_setname_np.3
>>> @@ -164,8 +164,9 @@ THREADFOO
>>>   
>>>   #define NAMELEN 16
>>>   
>>> -#define errExitEN(en, msg) \e
>>> -            do { errno = en; perror(msg); exit(EXIT_FAILURE); \e
>>> +#define errExitEN(en, msg) do \e
>>> +        { \
>>> +            errno = en; perror(msg); exit(EXIT_FAILURE); \e
>>>           } while (0)
>>>   
>>>   static void *
>>>
>>
>>


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/