Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp211438pxk; Fri, 11 Sep 2020 04:58:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzruQihVukGi4FarsxPkRrUokuEeknJXNQfSUWkM0lIQlyJ9epZ9Wl8KEcq0edXBzkqtRgS X-Received: by 2002:a05:6402:d8:: with SMTP id i24mr1568643edu.294.1599825530651; Fri, 11 Sep 2020 04:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599825530; cv=none; d=google.com; s=arc-20160816; b=qIdUyxnE/e/jxbjLF1YFPfBM1NSj+lg9bS+th4cA/c1rO8i+r5G5212BGm5AlSn2ep YKcL6QJCYrdAkRB16ZfcehLiNw7fyxvOxLXDxD2BgAoJLHuhfgxr5tMG5uhBSqHgq5RG trKLF6jHx8JuyWYiEA/fNFCEV6c+x7FTvqkQMTjw0FBCaugDZBu0UKn1flPPtSNyOrUT BM7ScP2Bm58z9004FC9k3CpReqU8JDvHg1ZZIyYyh9kiC3OVX2qmcE1InQcQQjnhy2cD eVkS8ok2tL6b5h/xUjvge0Bq7Rf7QC8FBo6FwW53/TJ+t5rR009Hjw8h2yV4dQd1aZSD VKnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LQOgAw+oj+1yumhk3TQifP6C7R8RckBcpxp146wKNS4=; b=fEvqKzAke7KeyfIoNqG7GpJVKDKehWpv0SGkvRT2hTmrylJP9+1fDWVhoI6b5g39WN pIIZsHmfnCJKivA6n0TYli6tUrI40XE6m+rAku95wOhhgxWUrax/gSmSIAq8hcw27Vfy nNiMeY2nohmB6lMfJFJZTsAnlHLpulNexUKGIrGCnN5iUb2qRCgE3IKXdnMO6X/7XOEY rnoA+xnPbFmQATs/2m86gGZ0E9/DvsY5p1aUaeoLIpmJeJwV9QsFMJoIIyJjYK5NrcFv MyXySMKxK5VYfe8htkmuiYlPDQHdQKA6R8h6dfx2GUrdW2KdyM65eaFv7LdHIDIhBRF1 an6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HmkktZev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b9si1090942edn.499.2020.09.11.04.58.27; Fri, 11 Sep 2020 04:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HmkktZev; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725808AbgIKL5u (ORCPT + 99 others); Fri, 11 Sep 2020 07:57:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:35032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgIKL5s (ORCPT ); Fri, 11 Sep 2020 07:57:48 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0EE6221E7; Fri, 11 Sep 2020 11:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599825466; bh=OGz8xp4DfNbeDLLobWhgOPaKtHeGjBzxJ1PU9o8tCI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HmkktZevp+Gs6mdLYJRyYRMZq9zekb9HXwVQ+kbJ2ZqfxN5gL02wCFOKbZHCVLuf1 TdoaPTQtk4bYdFitgdzZTfz6RVOiJRoJtqokUWCNOTwRLGP69kDsyemX+KBPLX89wc Cl41jfFTQSeI0hKl/37dzwzPHmzDoKhW4F6Efe9I= Date: Fri, 11 Sep 2020 13:57:52 +0200 From: Greg Kroah-Hartman To: Saeed Mahameed Cc: Saeed Mahameed , linux-kernel@vger.kernel.org, stable@vger.kernel.org, netdev@vger.kernel.org, Roi Dayan Subject: Re: [PATCH 4.19] net/mlx5e: Don't support phys switch id if not in switchdev mode Message-ID: <20200911115752.GA3717176@kroah.com> References: <20200807020542.636290-1-saeedm@mellanox.com> <20200807131323.GA664450@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 10, 2020 at 11:46:36AM -0700, Saeed Mahameed wrote: > On Fri, 2020-08-07 at 15:13 +0200, Greg Kroah-Hartman wrote: > > On Thu, Aug 06, 2020 at 07:05:42PM -0700, Saeed Mahameed wrote: > > > From: Roi Dayan > > > > > > Support for phys switch id ndo added for representors and if > > > we do not have representors there is no need to support it. > > > Since each port return different switch id supporting this > > > block support for creating bond over PFs and attaching to bridge > > > in legacy mode. > > > > > > This bug doesn't exist upstream as the code got refactored and the > > > netdev api is totally different. > > > > > > Fixes: cb67b832921c ("net/mlx5e: Introduce SRIOV VF representors") > > > Signed-off-by: Roi Dayan > > > Signed-off-by: Saeed Mahameed > > > --- > > > Hi Greg, > > > > > > Sorry for submitting a non upstream patch, but this bug is > > > bothering some users on 4.19-stable kernels and it doesn't exist > > > upstream, so i hope you are ok with backporting this one liner > > > patch. > > > > Also queued up to 4.9.y and 4.14.y. > > > > Hi Greg, the request was originally made for 4.19.y kernel, > I see the patch in 4.9 and 4.14 but not in 4.19 can we push it to 4.19 > as well ? Very odd, don't know what happened. Now fixed up, thanks. greg k-h