Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 13:17:41 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>
Cc:     Ard Biesheuvel <ard.biesheuvel@arm.com>,
        Ashish Kumar <ashish.kumar@nxp.com>,
        Yogesh Gaur <yogeshgaur.83@gmail.com>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Varun Sethi <V.Sethi@nxp.com>,
        Arokia Samy <arokia.samy@nxp.com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
        Paul Yang <Paul.Yang@arm.com>
Subject: Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support
Message-ID: <20200911121741.GE4895@sirena.org.uk>
References: <20200911082806.115-1-kuldip.dwivedi@puresoftware.com>
 <20200911110018.GD4895@sirena.org.uk>
 <9a6ce5d0-2f39-eb55-c3a9-cae2a8093fbc@arm.com>
 <01f42ace75808be76c78a4a67b78ec06@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="YToU2i3Vx8H2dn7O"
Content-Disposition: inline
In-Reply-To: <01f42ace75808be76c78a4a67b78ec06@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--YToU2i3Vx8H2dn7O
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 11, 2020 at 05:32:24PM +0530, Kuldip Dwivedi wrote:

> Here I can think two possible approaches
> 1. Changes in DT to use indexed based lookup

This is not going to be OK, it will break existing users relying on the
naming and makes the DTs less usable.

> 2. We Can check for ACPI fw node to distinguish between DT and ACPI like
> below..
> if (is_acpi_node(f->dev->fwnode))
> 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> else
> 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "fspi_base");

Yes, this should be good.

--YToU2i3Vx8H2dn7O
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9bauQACgkQJNaLcl1U
h9BCRgf/aL1RCrVtTo2njbYaoY5i0SRm99fj3cZHlaj3+XVyYLSWPwQbIIp+OqxC
7qgamDvL3xPUFzoCcoGMsrSO6I521jApV4Nr0Px8obDAPelh+1DMiVwoV5ZcjlFf
kdAe13mqJhO9KZrIjv/xKAWuhs84RyoTrrElxMD75M1tC/vrTINpcxx/98fhaPd/
/7QKLCssrtwOiQeRjuEwTLSYHcKDogJkIc6wQqL7UvsjSUVbOS5M9RyHqoTs+Mo1
drpX/v5NiKd4kfBgm5h7nFwrQqvlr9XLRyucJZnPUjNXaBZzi6Vpk4bHna9t67gv
b1HIZ8gxxAlT4im0VtW19gCzrDek3A==
=76Fx
-----END PGP SIGNATURE-----

--YToU2i3Vx8H2dn7O--