Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 08:38:25 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Luo Jiaxing <luojiaxing@huawei.com>, <mcoquelin.stm32@gmail.com>
Cc:     <peppe.cavallaro@st.com>, <alexandre.torgue@st.com>,
        <joabreu@synopsys.com>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>
Subject: Re: [PATCH net-next] net: stmmac: set get_rx_header_len() as void
 for it didn't have any error code to return
Message-ID: <20200911083825.55eb2f49@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <1599796558-45818-1-git-send-email-luojiaxing@huawei.com>
References: <1599796558-45818-1-git-send-email-luojiaxing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 11 Sep 2020 11:55:58 +0800 Luo Jiaxing wrote:
> We found the following warning when using W=3D1 to build kernel:
>=20
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variab=
le =E2=80=98ret=E2=80=99 set but not used [-Wunused-but-set-variable]
> int ret, coe =3D priv->hw->rx_csum;
>=20
> When digging stmmac_get_rx_header_len(), dwmac4_get_rx_header_len() and
> dwxgmac2_get_rx_header_len() return 0 only, without any error code to
> report. Therefore, it's better to define get_rx_header_len() as void.
>=20
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>

Reviewed-by: Jakub Kicinski <kuba@kernel.org>