Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp374889pxk; Fri, 11 Sep 2020 09:13:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPy3bgHl/dc62U+kjmJ8dBWBzKtRQk9eYTMGUEKELVjm9+mXXeM/zlti2uTCz8RnPYSzYF X-Received: by 2002:a17:906:e50:: with SMTP id q16mr2889343eji.544.1599840816051; Fri, 11 Sep 2020 09:13:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599840816; cv=none; d=google.com; s=arc-20160816; b=GMonulFdBjCOyfgCcawFoqMsjB879mxbQ8hi3ekDhQ36RZGWhJCrTHFksQjsYD2mxg a/5s+IN1J+vpxd8iuqZFUH7p/MG+nkH5pkY5HFu36EnixZsJ0qocTi63amLYTj5M5RQW 2kgR4592M/lzDC7A0AAkXgTe2ciMYelb7pxrVgmoc22AFdKk7C+/h2ehcx8LqWuuhp2f MLBkw5dZ1Y/2gDc5vYsABV/WXg39eA26jnl0ptF865V1+iWOiIJXzZatnsOged8ZAaUt QUYOnfn9qJL4UUjSp6PiLIClroPM1eYcSa9A1AmDBfF9UlRcGqYSIM729CWYREXKN4su CBZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=dLeT7KFOofVNutwmXWg7C/fdmcebGqCSDn3/nZjCzkw=; b=DQ81Xqdrl3yNiIvf6voYq3UgPfpmNEnQydmbR7f8NLu9vZgiRgfQeY+LD0/746oYHP tzXtycSnDGSkpvyxc2087Xb+qJUWG8iNbl03e7Rhmsa87uJwPVN5l7R35fJCm7e4KSMF KC27KnG/iVpd/waraJRIJ2HB927cA+2dakrPejrdaf02xDj2jucGlBFr3xr06xfpiDvn 3aqA5YpQwUN0EKkBwqif0uN7+9pG/n7DVFsH/hRKoCYYVrAwZGKLiZ2LKqmhQoSKZbp6 1l2WUIONQmUI7MpHQCa4OvDs3tDKFJcA/cyQNQWz0gs9UA5dKqTIanF1Hc+sgD0E7NDt 7m2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UcQ8GDd4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c12si1810452edx.274.2020.09.11.09.13.12; Fri, 11 Sep 2020 09:13:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UcQ8GDd4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726262AbgIKQLv (ORCPT + 99 others); Fri, 11 Sep 2020 12:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbgIKPhH (ORCPT ); Fri, 11 Sep 2020 11:37:07 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E765CC061757; Fri, 11 Sep 2020 08:35:52 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id n25so12802519ljj.4; Fri, 11 Sep 2020 08:35:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dLeT7KFOofVNutwmXWg7C/fdmcebGqCSDn3/nZjCzkw=; b=UcQ8GDd4FuKg1Z0S0GlIEt/Fvd6pdZfR/1e51QRBNnjS5POIP8uCnADrGHDr6oXXOu x0S4O08By+9kkDoMVoD6Hj9/+TP2OFRGvKa6Pok3Oy3gGnm2RnY9uwsP4YwsDnqEGnRI iiL5bsIs5CvoFJy0F4LxuiDOV9kVIqz2drn8fZU+x3fGaaZI+BADFvFR2J/xIHeBoI/I CwiEfKwP/1tAc29ZEuSZOzB5NotqrIqukilt+EUeufFqX6Zhi+nSH/JL5328Vr4Q3JB7 tfXQk7QW5FH4goaEyw6x3G41AAR0J40G+Vv32/d1Atp5TwhWEJuUGkvu5GXFSWuV4vW2 9yOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dLeT7KFOofVNutwmXWg7C/fdmcebGqCSDn3/nZjCzkw=; b=O6beAa/+OYxyhG+5J2Uor2bZ+9B6BcD5fWtWkBl6VcRZTAPpAwGUS79B7vCPgqw5Zv GVPV8gDFcjW0UG+1Axd4z+0pq5w0ut8cYAcmYnf1RPVUwxecNyQmPuZSz/7gVAlJO4kA aj7TxWHZivomYwrgGgjB9F4RqB7Mgh7Ajv2TEX+YRbtRQ15HdZ8pjuKMEYRycGikvdV9 CFDxZrD/mCp02cC/paCHgzBSWYTLzI2Ra6+C9cVtpqZgGFLU/ywZudW/Ngfwqjqr8/Sh LVBMPxfjj6ovukENz4LZ8/Y6hkkDpBdfUwu99MareEKJyCjf+KbK+rU7mD1yJefDZhzo rLnw== X-Gm-Message-State: AOAM532VURuG67bZPwMKMLLUuv1kGYF2bTp+VfSGD84qvLh96LJ2cTs+ 7hYKoHAGGgOMQmhtjF1IjpeD2WvqGe8vntu8Udj/gcHl X-Received: by 2002:a2e:b4ca:: with SMTP id r10mr727487ljm.452.1599838551377; Fri, 11 Sep 2020 08:35:51 -0700 (PDT) MIME-Version: 1.0 References: <20200911150139.13690-1-matthias.schiffer@ew.tq-group.com> In-Reply-To: <20200911150139.13690-1-matthias.schiffer@ew.tq-group.com> From: Fabio Estevam Date: Fri, 11 Sep 2020 12:35:40 -0300 Message-ID: Subject: Re: [PATCH] i2c: mxs: use MXS_DMA_CTRL_WAIT4END instead of DMA_CTRL_ACK To: Matthias Schiffer Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , linux-i2c , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On Fri, Sep 11, 2020 at 12:01 PM Matthias Schiffer wrote: > > The driver-specific usage of the DMA_CTRL_ACK flag was replaced with a > custom flag in commit ceeeb99cd821 ("dmaengine: mxs: rename custom flag"), > but i2c-mxs was not updated to use the new flag, completely breaking I2C > transactions using DMA. > > Fixes: ceeeb99cd821 ("dmaengine: mxs: rename custom flag") > Signed-off-by: Matthias Schiffer Thanks for the fix: Reviewed-by: Fabio Estevam