Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.60.83 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01;
Date:   Fri, 11 Sep 2020 09:27:08 -0700
From:   Hyun Kwon <hyun.kwon@xilinx.com>
To:     Daniel Vetter <daniel@ffwll.ch>
Cc:     Jason Yan <yanaijie@huawei.com>,
        "laurent.pinchart@ideasonboard.com" 
        <laurent.pinchart@ideasonboard.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        Michal Simek <michals@xilinx.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] drm: xlnx: remove defined but not used
 'scaling_factors_666'
Message-ID: <20200911162708.GA3715173@xilinx.com>
References: <20200910140630.1191782-1-yanaijie@huawei.com>
 <20200910181418.GA3187626@xilinx.com>
 <20200911081519.GM438822@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200911081519.GM438822@phenom.ffwll.local>
Content-Transfer-Encoding: quoted-printable
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2020 16:27:10.8113
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 81d8a328-5ba8-450e-6ffc-08d8566f88ba
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-AuthSource: CY1NAM02FT040.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR02MB6110
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Daniel,

On Fri, Sep 11, 2020 at 01:15:19AM -0700, Daniel Vetter wrote:
> On Thu, Sep 10, 2020 at 11:14:18AM -0700, Hyun Kwon wrote:
> > Hi Jason,
> >=20
> > On Thu, Sep 10, 2020 at 07:06:30AM -0700, Jason Yan wrote:
> > > This addresses the following gcc warning with "make W=3D1":
> > >=20
> > > drivers/gpu/drm/xlnx/zynqmp_disp.c:245:18: warning:
> > > =E2=80=98scaling_factors_666=E2=80=99 defined but not used [-Wunuse=
d-const-variable=3D]
> > >   245 | static const u32 scaling_factors_666[] =3D {
> > >       |                  ^~~~~~~~~~~~~~~~~~~
> > >=20
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: Jason Yan <yanaijie@huawei.com>
> >=20
> > Reviewed-by: Hyun Kwon <hyun.kwon@xilinx.com>
>=20
> I think you're the maintainer, so please also push patches to
> drm-misc-next. Otherwise they'll just get lost, or at least it's very
> confusing when a maintainer reviews a patch but there's no indication w=
hat
> will happen with the patch.

Right. I wanted to give it some time before pushing. I'll clearly state g=
oing
forward.

Thanks,
-hyun

> -Daniel
>=20
> >=20
> > Thanks!
> >=20
> > -hyun
> >=20
> > > ---
> > >  drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 ------
> > >  1 file changed, 6 deletions(-)
> > >=20
> > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/x=
lnx/zynqmp_disp.c
> > > index a455cfc1bee5..98bd48f13fd1 100644
> > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > > @@ -242,12 +242,6 @@ static const u32 scaling_factors_565[] =3D {
> > >  	ZYNQMP_DISP_AV_BUF_5BIT_SF,
> > >  };
> > > =20
> > > -static const u32 scaling_factors_666[] =3D {
> > > -	ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > -	ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > -	ZYNQMP_DISP_AV_BUF_6BIT_SF,
> > > -};
> > > -
> > >  static const u32 scaling_factors_888[] =3D {
> > >  	ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > >  	ZYNQMP_DISP_AV_BUF_8BIT_SF,
> > > --=20
> > > 2.25.4
> > >=20
>=20
> --=20
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch