Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Sep 2020 16:27:12 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Tony Lindgren <tony@atomide.com>
Cc:     khilman@kernel.org, linux@armlinux.org.uk,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] omap3: enable off mode automatically
Message-ID: <20200911162712.740d96ec@aktux>
In-Reply-To: <20200911103337.GH7101@atomide.com>
References: <20200911064924.26281-1-andreas@kemnade.info>
        <20200911103337.GH7101@atomide.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 11 Sep 2020 13:33:37 +0300
Tony Lindgren <tony@atomide.com> wrote:

> * Andreas Kemnade <andreas@kemnade.info> [200911 09:50]:
> > --- a/arch/arm/mach-omap2/pm.h
> > +++ b/arch/arm/mach-omap2/pm.h
> > @@ -49,11 +49,7 @@ static inline int omap4_opp_init(void)
> >  extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
> >  extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
> >  
> > -#ifdef CONFIG_PM_DEBUG
> >  extern u32 enable_off_mode;
> > -#else
> > -#define enable_off_mode 0
> > -#endif  
> 
> Hmm isn't the above still needed for the other SoCs? Or is omap3 the only
> user?
> 
well, the linker moans about undefined symbols if
CONFIG_ARCH_OMAP3 is not enabled.
I will send a v2.

Regards,
Andreas