Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 00/13] bus/fsl-mc: Extend mc-bus driver functionalities
 in preparation for mc-bus VFIO support
To:     Diana Craciun <diana.craciun@oss.nxp.com>,
        linux-kernel@vger.kernel.org
Cc:     stuyoder@gmail.com, leoyang.li@nxp.com, gregkh@linuxfoundation.org,
        linux-arm-kernel@lists.infradead.org, bharatb.linux@gmail.com
References: <20200826092527.4992-1-diana.craciun@oss.nxp.com>
From:   Laurentiu Tudor <laurentiu.tudor@nxp.com>
Message-ID: <1e61ea66-7b3b-cc3a-742e-1f3897cb2372@nxp.com>
Date:   Fri, 11 Sep 2020 17:33:29 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
In-Reply-To: <20200826092527.4992-1-diana.craciun@oss.nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.103] (86.123.62.53) by AM4PR0202CA0015.eurprd02.prod.outlook.com (2603:10a6:200:89::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 14:33:32 +0000
X-Originating-IP: [86.123.62.53]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: ea096730-f335-4b19-cd2b-08d8565fa8d1
X-MS-TrafficTypeDiagnostic: VI1PR0401MB2319:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0401MB2319F206AE4F631FD5A7922BEC240@VI1PR0401MB2319.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UzGdnv6K2lEi3QmOfE6+3/lT8ArbpjAFnZhl2lTISD4Wllw3wZ5zmhUEOQUoIK0+xiCYqAOCBUKnACAJRcMa5okBcqfI8r1TonDKscul/y47n4A67KvwiEeQgPUPA24NDLqk7h4+khWqGE1CbGDjhhbm2njmKpp4CMNBzyovIyF8Fe7ned0pjBX1bjOcu4fglUKx9gvYX0gBtAv8huQgk6cZtcsV42PRm2CPfnEqwODxr1rhC1zJ9wGesYajKy/9JMKOALNlG0IJScKxlog4XoweTM4O/xI7Kzq2RB+ymU/8QhL6wDESD6SlLlrUtk7893REm1RzpyPcXRLsXLgmnKW62Ao/BSWd1ZDCEgYBaqfmvXyjozZNY+jFHhhfhPHA
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3405.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(136003)(366004)(396003)(478600001)(83380400001)(186003)(8676002)(31696002)(2906002)(8936002)(31686004)(5660300002)(53546011)(26005)(16526019)(66946007)(6486002)(66556008)(66476007)(956004)(16576012)(4326008)(36756003)(44832011)(6666004)(2616005)(316002)(52116002)(86362001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: o7rF4QPygs6eKHamNzMvHGoNlYdmiicxhnLtIXCJTCx6AIg7XUsrANIZSMnvhnFkuQuLh+7u/RyWBZbkZHcsLqh9fJeN5gqPkYQYdoogyIslnisCg0f1xyBewwtP6tUKFznwFokxYvtEN7AJKjrL1/4cazordvzNVebsPu0x2Ip9ZtXh22azWTSy9CuO/Qokwau1J4fXmiciN0TBJ1zXkkmeW2pRVszOonIslOAgGs9D6EcnytscnF7lNPEmvs/lM2hiKifq2XfWuh0NoXDrJQO1R1vNRKM25Tjo4zrAXkOnFC93IAqkti079X2m1e8zQGMdMJRZQlF5DqtetJ8RYWR3M9HfgDqd0S4fbByzhoQ0Lnhw4/uAIKHszg1az3lTX1t2UbjvOXKp7hhUIbp8wZsNzA4dXeXBSrfvrPaE2t8PMk8G7jHOd2hdOF+Lw1TiWJ/oltQUhiztp+2LIOO3mCHvWXRRr1q3TQeu6MU9cLKUmVlBRbkoAsGCCrMyyjKiqBiJeoi2s4UXQT1YTSCoxsiuKMCrXaq7Q5CoqsLqMoLHMscxs5ITCd34tBmKLtZBQ2BBdoY1BT0DKt0EJmiWf6Y4S2FjBqULNpe+jUgUWiuAd98zLra5gEja3TcS3mVXNUfH+TGsPPpQDVo41LFBFQ==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea096730-f335-4b19-cd2b-08d8565fa8d1
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3405.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2020 14:33:33.2325
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qj9XhKeP4YVM4Ec9+qT3BPbxetgQ2ooB3AVhyQOkwBp8z8Vze8SILB/eTcA7XCYdK56wFp3C0QAQkBhvkmiLXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2319
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/26/2020 12:25 PM, Diana Craciun wrote:
> The vfio-mc bus driver needs some additional services to be exported by the
> mc-bus driver like:
> - a way to reset the DPRC container
> - driver_override support
> - functions to setup/tear down a DPRC
> - functions for allocating the pool of interrupts. In case of VFIO the
> interrupts are not configured at probe time, but later by userspace
> request
> 
> v3 -> v4
> - Rebased on the latest kernel.
> - Exported a dprc_remove function
> 
> v2 -> v3
> - Add a new version for dprc_get_obj_region
> - Export the cacheability bus specific bits defines
> 
> v1 -> v2
> - Remove driver_override propagation through various functions
> - Cache the DPRC API version
> 
> The patches are related with "vfio/fsl-mc: VFIO support for FSL-MC
> devices" patches, but the series were split because they are targeting
> different subsystems. However, the mc-bus patches may suffer changes
> when addressing the VFIO review comments.
> 
> The patches do not address the comment regarding moving driver_override
> in the core code. I prefer not to tie these patches on that change and
> address that separately.
> 
> Bharat Bhushan (3):
>   bus/fsl-mc: add support for 'driver_override' in the mc-bus
>   bus/fsl-mc: Add dprc-reset-container support
>   bus/fsl-mc: Extend ICID size from 16bit to 32bit
> 
> Diana Craciun (10):
>   bus/fsl-mc: Do no longer export the total number of irqs outside
>     dprc_scan_objects
>   bus/fsl-mc: Add a new parameter to dprc_scan_objects function
>   bus/fsl-mc: Set the QMAN/BMAN region flags
>   bus/fsl-mc: Cache the DPRC API version
>   bus/fsl-mc: Export dprc_scan/dprc_remove functions to be used by
>     multiple entities
>   bus/fsl-mc: Export a cleanup function for DPRC
>   bus/fsl-mc: Add a container setup function
>   bus/fsl_mc: Do not rely on caller to provide non NULL mc_io
>   bus/fsl-mc: Export IRQ pool handling functions to be used by VFIO
>   bus/fsl-mc: Add a new version for dprc_get_obj_region command
> 
>  drivers/bus/fsl-mc/dprc-driver.c      | 175 ++++++++++++++++----------
>  drivers/bus/fsl-mc/dprc.c             | 141 +++++++++++++++++----
>  drivers/bus/fsl-mc/fsl-mc-allocator.c |  12 +-
>  drivers/bus/fsl-mc/fsl-mc-bus.c       |  64 +++++++++-
>  drivers/bus/fsl-mc/fsl-mc-private.h   |  31 ++---
>  drivers/bus/fsl-mc/mc-io.c            |   7 +-
>  include/linux/fsl/mc.h                |  41 +++++-
>  7 files changed, 349 insertions(+), 122 deletions(-)
> 

For the series:
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>

---
Best Regards, Laurentiu