Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ashish Kumar <ashish.kumar@nxp.com>
To:     kuldip dwivedi <kuldip.dwivedi@puresoftware.com>,
        Yogesh Gaur <yogeshgaur.83@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Varun Sethi <V.Sethi@nxp.com>, Arokia Samy <arokia.samy@nxp.com>,
        Ard Biesheuvel <Ard.Biesheuvel@arm.com>,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
        Paul Yang <Paul.Yang@arm.com>,
        kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
Subject: RE: [EXT] [PATCH v3] spi: spi-nxp-fspi: Add ACPI support
Thread-Topic: [EXT] [PATCH v3] spi: spi-nxp-fspi: Add ACPI support
Thread-Index: AQHWiDv/t1nI+oMTeEK7wKGOom49QaljbOIA
Date:   Fri, 11 Sep 2020 13:25:57 +0000
Message-ID: <HE1PR04MB3196FE21A068CB251775C48395240@HE1PR04MB3196.eurprd04.prod.outlook.com>
References: <20200911130331.6313-1-kuldip.dwivedi@puresoftware.com>
In-Reply-To: <20200911130331.6313-1-kuldip.dwivedi@puresoftware.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fa753214-1429-443e-0186-08d8565637e2
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2020 13:25:57.6290
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +aU2v2ki5mqlvkja7o8jCjHY0DlJRC9zWbEJ9Ac4cFYEHSfU996XMh0GJGb2xD5D2BX2pn7qO2pQOl108hzWvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3115
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
> Sent: Friday, September 11, 2020 6:34 PM
> To: Ashish Kumar <ashish.kumar@nxp.com>; Yogesh Gaur
> <yogeshgaur.83@gmail.com>; Mark Brown <broonie@kernel.org>; linux-
> spi@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Varun Sethi <V.Sethi@nxp.com>; Arokia Samy <arokia.samy@nxp.com>;
> Ard Biesheuvel <Ard.Biesheuvel@arm.com>; Samer El-Haj-Mahmoud
> <Samer.El-Haj-Mahmoud@arm.com>; Paul Yang <Paul.Yang@arm.com>;
> kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
> Subject: [EXT] [PATCH v3] spi: spi-nxp-fspi: Add ACPI support
>=20
> Caution: EXT Email
>=20
> Currently NXP fspi  driver has support of DT only. Adding ACPI support to=
 the
> driver so that it can be used by UEFI firmware booting in ACPI mode. This
> driver will be probed if any firmware will expose HID "NXP0009" in DSDT
> table.
>=20
> Signed-off-by: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>
Reviewed-by: Ashish Kumar <Ashish.Kumar@nxp.com>

Regards=20
Ashish=20
> ---
>=20
> Notes:
>     1. Add ACPI match table, NXP members are added to confirm HID for FSP=
I
>     2. Change the DT specific APIs to device property APIs
>        so that same API can be used in DT and ACPi mode.
>     3. Add node specific checks to use indexed based lookup API in case o=
f
>        ACPI.
>         if (is_acpi_node(f->dev->fwnode))
>                 res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
>         else
>                 res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM=
,
> "fspi_base");
>     4. Omit clock configuration part - in ACPI world, the firmware
>        is responsible for clock maintenance.
>     5. This patch is tested on LX2160A platform
>=20
>  drivers/spi/spi-nxp-fspi.c | 69 +++++++++++++++++++++++++++-----------
>  1 file changed, 50 insertions(+), 19 deletions(-)
>=20
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c inde=
x
> 1ccda82da206..0d41406c036d 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -3,7 +3,8 @@
>  /*
>   * NXP FlexSPI(FSPI) controller driver.
>   *
> - * Copyright 2019 NXP.
> + * Copyright 2019-2020 NXP
> + * Copyright 2020 Puresoftware Ltd.
>   *
>   * FlexSPI is a flexsible SPI host controller which supports two SPI
>   * channels and up to 4 external devices. Each channel supports @@ -30,6
> +31,7 @@
>   *     Frieder Schrempf <frieder.schrempf@kontron.de>
>   */
>=20
> +#include <linux/acpi.h>
>  #include <linux/bitops.h>
>  #include <linux/clk.h>
>  #include <linux/completion.h>
> @@ -563,6 +565,9 @@ static int nxp_fspi_clk_prep_enable(struct nxp_fspi
> *f)  {
>         int ret;
>=20
> +       if (is_acpi_node(f->dev->fwnode))
> +               return 0;
> +
>         ret =3D clk_prepare_enable(f->clk_en);
>         if (ret)
>                 return ret;
> @@ -576,10 +581,15 @@ static int nxp_fspi_clk_prep_enable(struct
> nxp_fspi *f)
>         return 0;
>  }
>=20
> -static void nxp_fspi_clk_disable_unprep(struct nxp_fspi *f)
> +static int nxp_fspi_clk_disable_unprep(struct nxp_fspi *f)
>  {
> +       if (is_acpi_node(f->dev->fwnode))
> +               return 0;
> +
>         clk_disable_unprepare(f->clk);
>         clk_disable_unprepare(f->clk_en);
> +
> +       return 0;
>  }
>=20
>  /*
> @@ -1001,7 +1011,7 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)
>=20
>         f =3D spi_controller_get_devdata(ctlr);
>         f->dev =3D dev;
> -       f->devtype_data =3D of_device_get_match_data(dev);
> +       f->devtype_data =3D device_get_match_data(dev);
>         if (!f->devtype_data) {
>                 ret =3D -ENODEV;
>                 goto err_put_ctrl;
> @@ -1010,7 +1020,12 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)
>         platform_set_drvdata(pdev, f);
>=20
>         /* find the resources - configuration register address space */
> -       res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "fspi_base");
> +       if (is_acpi_node(f->dev->fwnode))
> +               res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +       else
> +               res =3D platform_get_resource_byname(pdev,
> +                               IORESOURCE_MEM, "fspi_base");
> +
>         f->iobase =3D devm_ioremap_resource(dev, res);
>         if (IS_ERR(f->iobase)) {
>                 ret =3D PTR_ERR(f->iobase); @@ -1018,7 +1033,12 @@ static=
 int
> nxp_fspi_probe(struct platform_device *pdev)
>         }
>=20
>         /* find the resources - controller memory mapped space */
> -       res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "fspi_mmap");
> +       if (is_acpi_node(f->dev->fwnode))
> +               res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1);
> +       else
> +               res =3D platform_get_resource_byname(pdev,
> +                               IORESOURCE_MEM, "fspi_mmap");
> +
>         if (!res) {
>                 ret =3D -ENODEV;
>                 goto err_put_ctrl;
> @@ -1029,22 +1049,24 @@ static int nxp_fspi_probe(struct platform_device
> *pdev)
>         f->memmap_phy_size =3D resource_size(res);
>=20
>         /* find the clocks */
> -       f->clk_en =3D devm_clk_get(dev, "fspi_en");
> -       if (IS_ERR(f->clk_en)) {
> -               ret =3D PTR_ERR(f->clk_en);
> -               goto err_put_ctrl;
> -       }
> +       if (dev_of_node(&pdev->dev)) {
> +               f->clk_en =3D devm_clk_get(dev, "fspi_en");
> +               if (IS_ERR(f->clk_en)) {
> +                       ret =3D PTR_ERR(f->clk_en);
> +                       goto err_put_ctrl;
> +               }
>=20
> -       f->clk =3D devm_clk_get(dev, "fspi");
> -       if (IS_ERR(f->clk)) {
> -               ret =3D PTR_ERR(f->clk);
> -               goto err_put_ctrl;
> -       }
> +               f->clk =3D devm_clk_get(dev, "fspi");
> +               if (IS_ERR(f->clk)) {
> +                       ret =3D PTR_ERR(f->clk);
> +                       goto err_put_ctrl;
> +               }
>=20
> -       ret =3D nxp_fspi_clk_prep_enable(f);
> -       if (ret) {
> -               dev_err(dev, "can not enable the clock\n");
> -               goto err_put_ctrl;
> +               ret =3D nxp_fspi_clk_prep_enable(f);
> +               if (ret) {
> +                       dev_err(dev, "can not enable the clock\n");
> +                       goto err_put_ctrl;
> +               }
>         }
>=20
>         /* find the irq */
> @@ -1127,6 +1149,14 @@ static const struct of_device_id nxp_fspi_dt_ids[]
> =3D {  };  MODULE_DEVICE_TABLE(of, nxp_fspi_dt_ids);
>=20
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id nxp_fspi_acpi_ids[] =3D {
> +       { "NXP0009", .driver_data =3D (kernel_ulong_t)&lx2160a_data, },
> +       {}
> +};
> +MODULE_DEVICE_TABLE(acpi, nxp_fspi_acpi_ids); #endif
> +
>  static const struct dev_pm_ops nxp_fspi_pm_ops =3D {
>         .suspend        =3D nxp_fspi_suspend,
>         .resume         =3D nxp_fspi_resume,
> @@ -1136,6 +1166,7 @@ static struct platform_driver nxp_fspi_driver =3D {
>         .driver =3D {
>                 .name   =3D "nxp-fspi",
>                 .of_match_table =3D nxp_fspi_dt_ids,
> +               .acpi_match_table =3D ACPI_PTR(nxp_fspi_acpi_ids),
>                 .pm =3D   &nxp_fspi_pm_ops,
>         },
>         .probe          =3D nxp_fspi_probe,
> --
> 2.17.1