Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 1/1] Input: atmel_mxt_ts - implement I2C retries
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Jiada Wang <jiada_wang@mentor.com>, nick@shmanahar.org,
        dmitry.torokhov@gmail.com
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew_Gabbasov@mentor.com, erosca@de.adit-jv.com
References: <20200908151617.12199-1-jiada_wang@mentor.com>
 <6041c677-592b-388e-2eb6-3287a3d92e4b@gmail.com>
Message-ID: <ec77e42c-ea72-bbae-e1b8-1e11cca17f87@gmail.com>
Date:   Fri, 11 Sep 2020 18:05:29 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <6041c677-592b-388e-2eb6-3287a3d92e4b@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

11.09.2020 17:50, Dmitry Osipenko пишет:
...
>> @@ -626,6 +627,7 @@ static int __mxt_read_reg(struct i2c_client *client,
>>  	struct i2c_msg xfer[2];
>>  	u8 buf[2];
>>  	int ret;
>> +	bool retry = false;

Andy suggested to write this hunk like this:

	struct i2c_msg xfer[2];
	bool retry = false;
	u8 buf[2];
	int ret;

This is not a mandatory request at all, but it will make this particular
piece of code to look a bit nicer.

There is also an opportunity to improve formatting of all variables by
sorting them by-length across the whole driver, this will improve
readability of the code. But of course it should be a separate patch.
Please note that I'm *not* saying that you should create this separate
patch!