Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp399335pxk; Fri, 11 Sep 2020 09:52:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyOudcdv4CipUawaIJba8cOpH93SyBh/JMIjWPbtgfFD/diVU14fQhztIgPfH49KLArujm X-Received: by 2002:aa7:d68c:: with SMTP id d12mr3208604edr.274.1599843139673; Fri, 11 Sep 2020 09:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599843139; cv=none; d=google.com; s=arc-20160816; b=rQ97+QS4/bo8H3vOuOKflORm5jQej2/OobHsF6yOwItjoTzpxjqk7H/fR0pMjQ+nk1 56npvxXrdiTpzeOC/7mvKotLig45z8+7hvF6bfCF4Cx6IuL4ZUEUcsujo0/TrjQbz7eb xWwZ6Gj2xNPz2aRnYbVIzJtE8cqMWjSb2/nDnhpQVJq/R1b/ujr8dZ4KvbTQo5P7e8GU UfKwaaTp3aw3vVYSp68lIgv1EbpkpeqfjMP2wmKG2R8R8NQ+k8JcpuP00DgG+lHBTBul +nGWnPCMZQ+jca63avJQ9JZYGvluB3hUk/y8ycPLU+yWBdeOJPqjmvofv6XdCYXbUKsY lVrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1qvhjcAGQcLAne7h+yzCxpfJe8lWTlZLMxveRwvae1M=; b=b5seq/KYe6F61yIGvECV3Y8mqFGW6xus1HCig9kDfgrwswsIXkTOO/uDhKIcjwWBxS NTYtkd3fz6HxCnmzkV6UB3uStCMJchcJSGrGqauWWYHpBzsferus9k0PBxwSq9ZfaLfp 4E2M8MxEC9HlVWIFtc3gvnqRi/HgnFFWKoltY7UOqWX+T9+1d3Y83QdxZfL4KE8pm2li EzuTlsL0t0an8fF0yopU1Bd5C6No1PgAN029Ws5DIjKo9pl+5jo69wrMOWdW51cMLwdY DdY/ma1gn3mZOZUkL9cocfrgY3BDsL0F1IRviqTQ02CjYVjJOHAjy8RfcWsuqyhg1Fu7 3/yQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si1594179ejx.142.2020.09.11.09.51.57; Fri, 11 Sep 2020 09:52:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbgIKQvQ (ORCPT + 99 others); Fri, 11 Sep 2020 12:51:16 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:59261 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbgIKQuV (ORCPT ); Fri, 11 Sep 2020 12:50:21 -0400 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 3AF331C0006; Fri, 11 Sep 2020 16:50:11 +0000 (UTC) From: Miquel Raynal To: Mark Tomlinson , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: artem.bityutskiy@linux.intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: mtdoops: Don't write panic data twice Date: Fri, 11 Sep 2020 18:50:10 +0200 Message-Id: <20200911165010.27563-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200903034217.23079-1-mark.tomlinson@alliedtelesis.co.nz> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: c1cf1d57d1492235309111ea6a900940213a9166 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-09-03 at 03:42:17 UTC, Mark Tomlinson wrote: > If calling mtdoops_write, don't also schedule work to be done later. > > Although this appears to not be causing an issue, possibly because the > scheduled work will never get done, it is confusing. > > Fixes: 016c1291ce70 ("mtd: mtdoops: do not use mtd->panic_write directly") > Signed-off-by: Mark Tomlinson Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel