Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To:     =?iso-8859-1?Q?Pali_Roh=E1r?= <pali@kernel.org>
CC:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dsterba@suse.cz" <dsterba@suse.cz>,
        "aaptel@suse.com" <aaptel@suse.com>,
        "willy@infradead.org" <willy@infradead.org>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "joe@perches.com" <joe@perches.com>,
        "mark@harmstone.com" <mark@harmstone.com>
Subject: RE: [PATCH v3 02/10] fs/ntfs3: Add initialization of super block
Thread-Topic: [PATCH v3 02/10] fs/ntfs3: Add initialization of super block
Thread-Index: AQHWfUklkImnkcPlKk6YxFGcmZ/fxalYOsKAgAuCx5A=
Date:   Fri, 11 Sep 2020 16:59:34 +0000
Message-ID: <948ac894450d494ea15496c2e5b8c906@paragon-software.com>
References: <20200828143938.102889-1-almaz.alexandrovich@paragon-software.com>
 <20200828143938.102889-3-almaz.alexandrovich@paragon-software.com>
 <20200904120625.2af76ebfnacbzwug@pali>
In-Reply-To: <20200904120625.2af76ebfnacbzwug@pali>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: linux-fsdevel-owner@vger.kernel.org <linux-fsdevel-owner@vger.kernel.=
org> On Behalf Of Pali Rohar
Sent: Friday, September 4, 2020 3:06 PM
>=20
> Hello Konstantin!
>=20
> On Friday 28 August 2020 07:39:30 Konstantin Komarov wrote:
> > +	if (nls_name[0]) {
> > +		sbi->nls =3D load_nls(nls_name);
> > +		if (!sbi->nls) {
> > +			ntfs_printk(sb, KERN_ERR "failed to load \"%s\"",
> > +				    nls_name);
> > +			return -EINVAL;
> > +		}
> > +	} else {
> > +		sbi->nls =3D load_nls_default();
> > +		if (!sbi->nls) {
> > +			ntfs_printk(sb, KERN_ERR "failed to load default nls");
> > +			return -EINVAL;
> > +		}
> > +	}
> > +
> > +	if (!strcmp(sbi->nls->charset, "utf8")) {
> > +		/*use utf16s_to_utf8s/utf8s_to_utf16s instead of nls*/
> > +		unload_nls(sbi->nls);
> > +		sbi->nls =3D NULL;
> > +	}
>=20
> You can slightly simplify this code to omit calling load_nls() for UTF-8.=
 E.g.:
>=20
>     if (strcmp(nls_name[0] ? nls_name : CONFIG_NLS_DEFAULT, "utf8") =3D=
=3D 0) {
>         /* For UTF-8 use utf16s_to_utf8s/utf8s_to_utf16s instead of nls *=
/
>         sbi->nls =3D NULL;
>     } else if (nls_name) {
>         sbi->nls =3D load_nls(nls_name);
>         if (!sbi->nls) {
>             /* handle error */
>         }
>     } else {
>         sbi->nls =3D load_nls_default();
>         if (!sbi->nls) {
>             /* handle error */
>         }
>     }

Hi Pali! Thanks! Applied, check out the v5 please.

Best regards