Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp429072pxk; Fri, 11 Sep 2020 10:37:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMetCfGalkPee9ycS8RfMd3GIPmVxzW3WxZtK/E4SLDh0OAC1trCjpFEkhYQcjnmbpAK3D X-Received: by 2002:a50:a165:: with SMTP id 92mr3428939edj.320.1599845825369; Fri, 11 Sep 2020 10:37:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599845825; cv=none; d=google.com; s=arc-20160816; b=zg1LEpAKC4Vh2skL7S435hZOxhFmJJcfsdZIiKA3pLWFHP3yBZAN08qScinz5NygdK 6IrQLJzzioTcgi2NehoEbL3DLbfv9ga2H+Mw8tZpgwcbudAO/x7Wn6pzFUho552C0mTy 7fwipapbqiWczz2nyfDdWNUT6nWmPFLtU3G2sEVaZeYRP/qefSYVakR1K1d5M8YyXlVa xafj9OPUBcVCrxCjPmBI5ZbeAdEGUGC1YBtz4KO1cLDQ6IH28rbphW9Yhmodmfow+k2y 9qA1vrvADEg2ZLpoapwVr79u24+/nThiPm6z8PuWSyk6CGz9HtnnWC+hOf5QAnYcIzxI I54A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=voC46Gar+OUz3EGEHwhvsV84TjJMpZxXA7gAj0oypKU=; b=O7Dy74aL+0byUhi76qX6Cso8Zlr5pdWEXbO/LEo5ZzVmvGkXeYR0jA+WXtBB/LRdxA g4coaZXT97jvaTQELVdRt3M9hHQcfwwBx6AmEJ19QgQulPHjKitu3ii6MjwxH38KOKbf Yf9vx/xHp8Ud1Ce2MYPxcAQqcLp+8wmXkoy6DjUsGHdAlD0B84ktAKkTztGNlIODG2Ip Fjkn/4/LAU+066PPWf72jfo9tmGgEjbgvbwh04YfFKjnrO+5VTtuf9znUAOWnrvuDgFX X6ZH9YfCy3Me414zJxfjSNTkLsde2EOZ1r9x1AL0ZhwIIztfSZsWt88fe0HNidEvIqM6 mECA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j9VgQ+Yi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sb9si1366715ejb.54.2020.09.11.10.36.42; Fri, 11 Sep 2020 10:37:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=j9VgQ+Yi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726425AbgIKRe2 (ORCPT + 99 others); Fri, 11 Sep 2020 13:34:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:49260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbgIKMye (ORCPT ); Fri, 11 Sep 2020 08:54:34 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4187022226; Fri, 11 Sep 2020 12:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599828836; bh=wo/9jfUs/QsfWHN0aWZWBzIi8v87Qpm/6HXW9VcwsdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j9VgQ+YiaSOt3ivWG0/baDmBcrg/vyXBC8xyq7QCpPc2L+K12KWYn4rIK0IjL0R7v OeTIwbngJtV8nSaTA6pzX2n2Mm/UlZdtArOHqUZFK5LoS6mJiUOcBmCZwkZXSxzUoP AR1c0dOlz1GEKMsNbbQnTCuOj/P60IjcPEfZ1Pto= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Layton , Ilya Dryomov , Sasha Levin Subject: [PATCH 4.4 06/62] ceph: dont allow setlease on cephfs Date: Fri, 11 Sep 2020 14:45:49 +0200 Message-Id: <20200911122502.716707091@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200911122502.395450276@linuxfoundation.org> References: <20200911122502.395450276@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Layton [ Upstream commit 496ceaf12432b3d136dcdec48424312e71359ea7 ] Leases don't currently work correctly on kcephfs, as they are not broken when caps are revoked. They could eventually be implemented similarly to how we did them in libcephfs, but for now don't allow them. [ idryomov: no need for simple_nosetlease() in ceph_dir_fops and ceph_snapdir_fops ] Signed-off-by: Jeff Layton Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Sasha Levin --- fs/ceph/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index c8222bfe1e566..3e6ebe40f06fb 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1433,6 +1433,7 @@ const struct file_operations ceph_file_fops = { .mmap = ceph_mmap, .fsync = ceph_fsync, .lock = ceph_lock, + .setlease = simple_nosetlease, .flock = ceph_flock, .splice_read = generic_file_splice_read, .splice_write = iter_file_splice_write, -- 2.25.1