Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
To:     x86@kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-edac@vger.kernel.org,
        linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org,
        devel@acpica.org
Cc:     Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Yazen Ghannam <yazen.ghannam@amd.com>,
        Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Subject: [PATCH v3 2/2] x86/mce/dev-mcelog: Fix updating kflags in AMD systems
Date:   Thu,  3 Sep 2020 18:45:31 -0500
Message-Id: <20200903234531.162484-3-Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <20200903234531.162484-1-Smita.KoralahalliChannabasappa@amd.com>
References: <20200903234531.162484-1-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ethanolx024ehost.amd.com (165.204.78.2) by DM6PR01CA0004.prod.exchangelabs.com (2603:10b6:5:296::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 20:42:28 +0000
X-Mailer: git-send-email 2.17.1
X-Originating-IP: [165.204.78.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: f73ee275-1d3d-4da9-33e1-08d85693334f
X-MS-TrafficTypeDiagnostic: SA0PR12MB4431:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SA0PR12MB4431807E12092DE403E0885B90240@SA0PR12MB4431.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tlZQmOFo9J2+yPi4OkzvIa51PLI1GVFdaSqjj95iuTg30y6cLm9fxj8mYCQfI6aaZtVk3Le365i7BFGZrQ+TKvlwmr9Eh0v3v2Cn0a0rtCL/bn63z+aZEOdd371dM18nynl9fipdAV75ShZUo1cDKasoBOhbOTauco6bzO/06rhI2t/kUYCA2AwizRajntKnKTpxYDPisxVw+ZObp+bvIkzb7jIpX+muliHsfiG8G8p4nE3qWQM5yYDTKKtWVMoSTp47Lfb7F+Cs3rmTkf0VN6DBVYtysKt0MuqROMmR0KzGPmu3XPa+4TXE3pQPAmuLaYJk9eXEIKIeBez6sVK0ObnDfC7443aL0nq/mRhPuEGDTUS2KSyQPi4+sjf0uAq65wN0u0ydx+lLNu110DMr2Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2685.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(376002)(346002)(136003)(396003)(8936002)(316002)(2616005)(8676002)(5660300002)(6666004)(956004)(54906003)(83380400001)(66946007)(1076003)(66476007)(52116002)(66556008)(36756003)(7696005)(7416002)(6486002)(966005)(16526019)(4326008)(2906002)(26005)(86362001)(478600001)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: M65F3wj3fTTG3jduktukXaKAk2m+nHLRATzXoakm0cD0TzV4PdfM/wO2vU4wqSOhxKSwritsWyopLGpDsArWE+sfixyPUtyKuXwq/vUzgsc1YEUFCl/Emf35cjNa0gty+OnikqB3OpgYUHiawNpGXU0LMQ57x+xGskJZBLukzqNOIDLk/EoQmOpO9ZTAGpztWiZ80CGwcI9OTvL+qVxL9l7E7fZdGJ6HAzn/YiXpSiop1izCqhkeKAAO5ei/MZQJVMasanV9DL3aLW8rFTdnSrBk/IkGEC66Oo15QMnhggJ0W8lXo5g6w0bUT1XR6T9u1IkSPW3CQldk+ow4SMiIHrFCr/KE8nivOyjH1ALvOLMfwVDARYNpbsivhBFFmPpKRzqWMyGvBNnvHRGrJY1gLx+CLFdm5UD5200naCzZ3uKP6uunpI7BO+K5c87Iq7B4Bt8RxNKIjW/aMAy2j4G/bfvqBTSTwp3dCnVkVad1oHqojraeGYRD3eUVfAM6ZpDtOTCY1T7Ci5v6sWAocOSWcJweZRfBTN7W7tziJu5Pvsw8rKjvnV+lnjURZCLzYwYO6VEbDOkFWf6v6h+982e7HS9OgswL16301+LWli1Pg54N7ju7lgghV/emq0PCQXOlrpYVBtWnYncEKJ3dl3cieg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f73ee275-1d3d-4da9-33e1-08d85693334f
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2020 20:42:29.5963
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o9gsPfHGolTSgucpevB0T8Xnu9gMgVwJAzIBvwzoYR+b/Mk8h1zoy90WJ+OPmiCijCVjfyZqLuHPRpYLJf6lKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4431
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The mcelog utility is not commonly used on AMD systems. Therefore, errors
logged only by the dev_mce_log() notifier will be missed. This may occur
if the EDAC modules are not loaded in which case it's preferable to print
the error record by the default notifier.

However, the mce->kflags set by dev_mce_log() notifier makes the default
notifier to skip over the errors assuming they are processed by
dev_mce_log().

Do not update kflags in the dev_mce_log() notifier on AMD systems.

Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
---
Link:
https://lkml.kernel.org/r/20200828203332.11129-3-Smita.KoralahalliChannabasappa@amd.com

v3:
	No change
v2:
	No change
---
 arch/x86/kernel/cpu/mce/dev-mcelog.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/mce/dev-mcelog.c b/arch/x86/kernel/cpu/mce/dev-mcelog.c
index 03e51053592a..100fbeebdc72 100644
--- a/arch/x86/kernel/cpu/mce/dev-mcelog.c
+++ b/arch/x86/kernel/cpu/mce/dev-mcelog.c
@@ -67,7 +67,9 @@ static int dev_mce_log(struct notifier_block *nb, unsigned long val,
 unlock:
 	mutex_unlock(&mce_chrdev_read_mutex);
 
-	mce->kflags |= MCE_HANDLED_MCELOG;
+	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
+		mce->kflags |= MCE_HANDLED_MCELOG;
+
 	return NOTIFY_OK;
 }
 
-- 
2.17.1