Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp564046pxk; Fri, 11 Sep 2020 14:27:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+FOQI0gLdicwI4KWizTOhErjOvgA/WjUh/lBolfKAfztPlKqOtV/W/hw6ZHkU3Y1TXgg7 X-Received: by 2002:aa7:ce19:: with SMTP id d25mr4611007edv.189.1599859655095; Fri, 11 Sep 2020 14:27:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1599859655; cv=pass; d=google.com; s=arc-20160816; b=EdgcnEH7x9rAwbXWbUXwJA105E5jjRe9XlO4hBD6zH9oUL/3WqWs7iy9LMEZORC5wq lE3drqlJykQyrl/Ej5E5aQBzTwmC3sd8IYPQLA3qg0MQgpV6q5BbezD0539Efqk71l+y UbTRZqoVzbu90efFfIbJHqTjKKXhPjXCbJ9+/YqmSxwbBXumFLlz9NUsempCQGrhyiBe dEvkgSMWe9nml0VMqNCMFjWj1UdBJyGevC8OapSuEPXWmoxdxFy4uCx8cXib+0tO5wEk eLl+bMBh5c4TxHgLrdNU24BryGxzJ0RIg8jlc83aI9+Lg/JSwPxGFK9uKBL3GU9Qlj71 LpPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-language :content-transfer-encoding:in-reply-to:user-agent:date:message-id :from:references:cc:to:subject:dkim-signature; bh=O6M+NfjK9CA8FevSRdWv/cuR98fCBZ2nswWVqG+sa3U=; b=WNVJyfd5AHp0knuNJfSsaWAsk5mGiRuGu9Yj9YFtCIz8DkQlvNEAADr0PmzCnehvgl s0MEshb/VVjLd2lcmOrSnaSv/YoCWHuYWxVhHYT0+g4PefU9bEiAbFyOoeRhhPI5kbLw PkiSVQ/NO9KjfH/nrz3O42HiwZ5IpZCvt8ssW8/VV4rib4YxAxGVWg/MnkH9F3FDF5YV XdNyxyj+ZVmRj4kVFO14JKaukhLJM3WlGnT5SxN2b12CSrgmXuUKfTvD58j8Hvto8y7q gIENq10Yn94pofADy0u/70ktZfyY1xlwhcQoSH2F2rxkHO+C78FmKeh6cY6oANxzwXbU 7lOg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=GJOGLbGg; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z9si2151317edp.477.2020.09.11.14.27.12; Fri, 11 Sep 2020 14:27:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=GJOGLbGg; arc=pass (i=1 spf=pass spfdomain=amd.com dkim=pass dkdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725888AbgIKV0a (ORCPT + 99 others); Fri, 11 Sep 2020 17:26:30 -0400 Received: from mail-bn8nam12on2080.outbound.protection.outlook.com ([40.107.237.80]:2903 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725816AbgIKV0V (ORCPT ); Fri, 11 Sep 2020 17:26:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AuPUlpjx18BuCPRk3ptNG3Tfs3TlEkp9CkNcS5qb3iJv39GUCngQRhWfQBoLT0ko6EXngj8ghBwbGXNxqhKBn3RsprAepAsZu70J66nIHLR9LZxW1dOytWUJ9dKLAvOR7hkOZwJtivV5mtame3rTgtRIz9coSq9tATpqsv0RjPUnzVpyfsLpB+ziAiNPgzm49+vJFejbviUe4UNRw6bojyJZSqX6Agxs5+GHNIuMs2fM44GPQWdYeKYI0sZFoflV+I2VW7narvsxR1V3XFb+S1UCYYIYOf0QsuqUOgMISf4HmHMWAvwlXYsIENOGuPbHIpfaoEa3XLUGoYxA8yWz7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O6M+NfjK9CA8FevSRdWv/cuR98fCBZ2nswWVqG+sa3U=; b=l1ddkgp4qbfTzd4I+F2qjqGS2FKAxXerBEic9OAcccQSbKdlvhmlB/C1G6GZDrPFtk3o9I4Plbw9lx6avX+7q3qILBOJCSKhfzWgC7cA/JHIxk8F3RM4LivvbFcIVS9kouZ9zYdYja5yIyftKcHtzqDZv3KviZqS6zSUxSLNMh42a27tFXCOfLvsuxSsfKkkEpdOSzgfTmB0nZrOBE3RRA6xdgKRPekwD7+UCV0vpiQcJG0ldML5y0jadTrn746jmNyZmiQeffbhVLf7bCPAvlfhQUfosgrExxMvUExFXJSlycr3Z1vIXhOzOfZtwXAE7HM+gXzB31yE+/Ezt266pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O6M+NfjK9CA8FevSRdWv/cuR98fCBZ2nswWVqG+sa3U=; b=GJOGLbGguf1vu6WMBKxzD6oe7fD5PM6RyXTwdi/B3FUhu3C1Ps5F9rYo+xhl2egwC3A/bcqwSv3SI38/lKK0dN8fuSvSjLAqz7Qo96wXP5cXY5f2y6IJri0fnpdAHyDllObGq5wflyfOXhcCrkKZgrH27EYO13+sbAZgirNa91k= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2685.namprd12.prod.outlook.com (2603:10b6:805:67::33) by SA0PR12MB4557.namprd12.prod.outlook.com (2603:10b6:806:9d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Fri, 11 Sep 2020 21:26:17 +0000 Received: from SN6PR12MB2685.namprd12.prod.outlook.com ([fe80::c0c8:60e:9d04:1409]) by SN6PR12MB2685.namprd12.prod.outlook.com ([fe80::c0c8:60e:9d04:1409%5]) with mapi id 15.20.3370.017; Fri, 11 Sep 2020 21:26:17 +0000 Subject: Re: [PATCH v2 1/2] cper, apei, mce: Pass x86 CPER through the MCA handling chain To: Ard Biesheuvel , Punit Agrawal Cc: X86 ML , Linux Kernel Mailing List , linux-pm@vger.kernel.org, linux-edac@vger.kernel.org, linux-efi , ACPI Devel Maling List , devel@acpica.org, Borislav Petkov , Tony Luck , "Rafael J . Wysocki" , Len Brown , Yazen Ghannam References: <20200828203332.11129-1-Smita.KoralahalliChannabasappa@amd.com> <20200828203332.11129-2-Smita.KoralahalliChannabasappa@amd.com> <878sdvv20h.fsf@kokedama.swc.toshiba.co.jp> <102d0c75-d642-8f8b-68c7-792499c2a62a@amd.com> <87a6y7qshg.fsf@kokedama.swc.toshiba.co.jp> From: Smita Koralahalli Channabasappa Message-ID: Date: Fri, 11 Sep 2020 16:26:15 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.2.1 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: DM6PR12CA0006.namprd12.prod.outlook.com (2603:10b6:5:1c0::19) To SN6PR12MB2685.namprd12.prod.outlook.com (2603:10b6:805:67::33) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2605:6000:101a:88d8:93:ec8d:8400:73ca] (2605:6000:101a:88d8:93:ec8d:8400:73ca) by DM6PR12CA0006.namprd12.prod.outlook.com (2603:10b6:5:1c0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16 via Frontend Transport; Fri, 11 Sep 2020 21:26:16 +0000 X-Originating-IP: [2605:6000:101a:88d8:93:ec8d:8400:73ca] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8adf0cdf-45d9-459d-dfd6-08d8569951df X-MS-TrafficTypeDiagnostic: SA0PR12MB4557: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QFGUxD0gHmembumRkNNNArVWF+iIKG39i6zwjEWh1f50EG+s4+wyJPzE/2uPMHvzZBvh4UOq1YVQIbj0eeG9mWXg1GpGRgr/aEIEiJuX3+YHdIEJVc9sZ416y7qbKpBdkGGQcaO2f7cFguRcooSPVb1UEJMOGmkS4T2CMqHxxGBFY7RdamfO6fWI1ZkNeavSRWQQmHV9ve8yrakIEI8AdZn/pWezfrxgLSWSZd7TLxE/XINoIp1NZGqsQRvCDNBMMnfXc8Cq2KR9Dif4jXqtHsszv78L0V2NmEliRG+kr/1REer5EKfS1D8lhq9FNbB6roj/3idG/iJPV6c+jjMm5Krs9CbsSOvOHpEGmXijFhFq0iOAg+v0e3eafp3d4wGHtyRaNRj7zu2LpBYsn3VxytDwn0sekIl2/4xVpUbIYpeV2Z8+SEHKZ+Gb0bZxrbXPQoewXCSLBR4KcUvM4uFAxg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2685.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(53546011)(31686004)(36756003)(2906002)(66946007)(66476007)(66556008)(5660300002)(16526019)(52116002)(8936002)(2616005)(8676002)(31696002)(7416002)(186003)(478600001)(6486002)(966005)(110136005)(4326008)(316002)(54906003)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 4B/FcQIj1KbnZ/kCgxJH8vcAkMwkZrRkClSzbYvZRYFnxls+gkbTg5cNC423fIKrAcq3BUPVwNIzLbQin7hf6Ic0cErI4Yxb62j6v3KttxyVFvVolyxDtB9bxcbg9CxZ/+6RBpzBxzNm9L4Zxin7mnBUgz2mBapBhGjhEA9NGkriueErx7M8YxwBeor5X73CYt2fjkSMT1qyxT0OH84G804IT971EuD5X7CIYdOuJPGG4RlKNyac3ycnirLfBZw0Bbjm8S8BrBgupazBCqETWs2nvceESvgrlCyBldTVFXo2NQWDbsiNc+y17uB3vW/j8B3bl08q2byqkHrazyusxVzchO/+CKkQyN2/7+xHuehl5Gbf5G7gLHd3MjbxkQVfS5pTFoQM6feE5pF2OYBCNDM2x+117uGPNAo8Pl3ct8d2ACyCMbb3vXR3khd5kMz4oz6gEf3q9DKiZoN0uslj90pCFkNd+8yFegw/INALxh+HkOJAOCMV2lxacssH6fZ2++oiRelhZNYQ/9e2WsTk9zdddqSYEdmR1OMIIMvbtN1IgfkdnRjmG+ijNQi6MsjSMv/0ZeRiUc4xP7vwVgMggejN4uuLETTUakC4eis9jKv6cE/SjTt0j45V480bBr4DmlmUwbHR94Nse/gBiICAIf98zlaT7lLjVb7HMqNIuoDHMUg4OZ/2IZ5Zyc9hjopwxPhU8i+xDqnA8D+gPToaUw== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8adf0cdf-45d9-459d-dfd6-08d8569951df X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2685.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2020 21:26:17.8035 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NdO4AyVzHjdxtT1rJSyrgFDbFKGJ2alCxuKLNfkq1knUzMLIEMcZChW3p+LC3VRJOwSrZEuXiN1fpZMoAiJ5rA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4557 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/20 1:23 PM, Ard Biesheuvel wrote: > On Thu, 3 Sep 2020 at 09:34, Punit Agrawal wrote: >> Hi Smita, >> >> Smita Koralahalli Channabasappa writes: >> >>> On 8/31/20 12:05 AM, Punit Agrawal wrote: >>> >>>> Hi Smita, >>>> >>>> A couple of comments below - >>>> >>>> Smita Koralahalli writes: >>>> >>>> [...] >>>> >>>> >>>>> diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c >>>>> index 2531de49f56c..374b8e18552a 100644 >>>>> --- a/drivers/firmware/efi/cper-x86.c >>>>> +++ b/drivers/firmware/efi/cper-x86.c >>>>> @@ -1,7 +1,7 @@ >>>>> // SPDX-License-Identifier: GPL-2.0 >>>>> // Copyright (C) 2018, Advanced Micro Devices, Inc. >>>>> -#include >>>> Why is the include dropped? AFAICT, the definitions from there are still >>>> being used after this patch. >>> Dropped because already includes >> Generally, you want to follow the rule that if a declaration from a >> header file is being used, it should show up in the includes. The same >> applies to both source as well as header files. >> >> It doesn't matter if another include in the source file in turn ends up >> including the same header again; the #ifdef guards are there to prevent >> duplicate declarations. >> >> The rationale is that if future changes remove the usage of >> , the C file can still be compiled after dropping the >> include; there should be no need to then re-introduce at >> that point. >> >> Hope that makes sense. >> > Agreed. If the code still uses declarations from linux/cper.h after > the patch, the #include should remain. Thanks, I have taken care of the comments and sent out the next revision now. https://lkml.kernel.org/r/20200903234531.162484-2-Smita.KoralahalliChannabasappa@amd.com. Please ignore my previous email. Thanks, Smita