Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp569628pxk; Fri, 11 Sep 2020 14:39:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmJdsWPwUFo2BAkZyxfQeK11CmreKthFPiCKOdheT7zftMbtfGsdOtsJvXwjpXbUqpW0FW X-Received: by 2002:aa7:d648:: with SMTP id v8mr4635726edr.159.1599860370900; Fri, 11 Sep 2020 14:39:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599860370; cv=none; d=google.com; s=arc-20160816; b=omvunc7FRqRV4tqZYKu7In3NNO3hBwjhoIKSUpn5z/dnIV3XY2XOIyZg/LsO+jmfIz VPcSI8Y3tbR+1aRoSp37nduQPBA4WJboGDSdmMC057UqD2Y9/7TT2RY+IbjBILFlRCgb 0SZbJalpARb35K5hilYXTBD/DV+J2S8tUcwgNkVQx5njcK3rDiwqBODgBIRSquCGDe7X SK/Ym+FRFRsRYw1vdeW0eBjJitSVgUrURfcjyXzRGG2T9uPWz6xyqd27M/XWUQkPofoj HOGKypy5KJjw0zNgS7ae6MPaAmqxeaZH2owNfJGt/rT3J2rbF9R2KE+IgKm6vuOsYL70 wL+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=FIA+rEXK2zKefFpIQZ7m+rU7+HO/KLVDkQ0NCmLzKnI=; b=mOm40qhmizcRbzzw85K64x0jPdyBqZjhBlU0Y8M9GM7/EMVRK+6i80IOoWEiaBf2Ie 3AO9rwVZfl44jgTxGFVOnVZ7FbwpOF1J4kXQEvLqW3HWEQfNnjX+gg26zjZnWL9UODyv giJPx+YYEvpHnF6Lj25Vt6YoO/UGdTmJv8r2FgJnmmOwRKNnwUp9tTD0LDHn7b0oTIR8 CPdL1oYURVxkZwJwQvf7mlbYcLyeNZBFnw07ewNJLesL0TBn/fDea/u8Rnh2ZuhIhfz1 51DpWNiBsQ7LPWgOmS0LiFCWmmmGQ/KRX+pMheAi6oAJYl7Drndgrga2b22j5t9SpHQj DlkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l12si2237280edt.99.2020.09.11.14.39.08; Fri, 11 Sep 2020 14:39:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725902AbgIKVhz (ORCPT + 99 others); Fri, 11 Sep 2020 17:37:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbgIKVhv (ORCPT ); Fri, 11 Sep 2020 17:37:51 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 533E8C061573; Fri, 11 Sep 2020 14:37:51 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 59C841366732A; Fri, 11 Sep 2020 14:21:03 -0700 (PDT) Date: Fri, 11 Sep 2020 14:37:49 -0700 (PDT) Message-Id: <20200911.143749.112207815452157120.davem@davemloft.net> To: luojiaxing@huawei.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH net-next] net: stmmac: set get_rx_header_len() as void for it didn't have any error code to return From: David Miller In-Reply-To: <1599796558-45818-1-git-send-email-luojiaxing@huawei.com> References: <1599796558-45818-1-git-send-email-luojiaxing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 Content-Transfer-Encoding: base64 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 11 Sep 2020 14:21:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org RnJvbTogTHVvIEppYXhpbmcgPGx1b2ppYXhpbmdAaHVhd2VpLmNvbT4NCkRhdGU6IEZyaSwgMTEg U2VwIDIwMjAgMTE6NTU6NTggKzA4MDANCg0KPiBXZSBmb3VuZCB0aGUgZm9sbG93aW5nIHdhcm5p bmcgd2hlbiB1c2luZyBXPTEgdG8gYnVpbGQga2VybmVsOg0KPiANCj4gZHJpdmVycy9uZXQvZXRo ZXJuZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX21haW4uYzozNjM0OjY6IHdhcm5pbmc6IHZhcmlh YmxlIKFyZXSiIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdDQo+ IGludCByZXQsIGNvZSA9IHByaXYtPmh3LT5yeF9jc3VtOw0KPiANCj4gV2hlbiBkaWdnaW5nIHN0 bW1hY19nZXRfcnhfaGVhZGVyX2xlbigpLCBkd21hYzRfZ2V0X3J4X2hlYWRlcl9sZW4oKSBhbmQN Cj4gZHd4Z21hYzJfZ2V0X3J4X2hlYWRlcl9sZW4oKSByZXR1cm4gMCBvbmx5LCB3aXRob3V0IGFu eSBlcnJvciBjb2RlIHRvDQo+IHJlcG9ydC4gVGhlcmVmb3JlLCBpdCdzIGJldHRlciB0byBkZWZp bmUgZ2V0X3J4X2hlYWRlcl9sZW4oKSBhcyB2b2lkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogTHVv IEppYXhpbmcgPGx1b2ppYXhpbmdAaHVhd2VpLmNvbT4NCg0KQXBwbGllZCwgdGhhbmsgeW91Lg0K