Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp574649pxk;
        Fri, 11 Sep 2020 14:50:46 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJztIrqxDqATHMdyjk0rmbtQ6ZqGd+U3dNioM/7eZCDipwfMo1tUAedv9Ao/0agtDQMpYXjb
X-Received: by 2002:a17:906:1f43:: with SMTP id d3mr3704054ejk.295.1599861046389;
        Fri, 11 Sep 2020 14:50:46 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1599861046; cv=none;
        d=google.com; s=arc-20160816;
        b=g+tRMaznAf2HTFP9QDiX8K/rAxHN2euW/StMmhtX43itVwudePSKjs5aJZsiiTg8+t
         64AgcA/TnJECIofc5MsbFiPeuaC/dKpHWZ/Ne2Sav1qc+IQb0fwaTx/L9BzQUUkmf7jv
         UHe5u2IBrCHwFx6VcSH49hbvGCewWpT9t6t9N/GWJpdEfahftxTLzjOJKVuMuYePmVd0
         MkO18JSdKKkoxy7fyguLE4AJibDLxd6JjTSty0UZfedIwlob4ZfzBVPj9/fG6wyeQg31
         wWigtoFedEUr0I+V6Q/tfbfze6mAS+wWq7qNzUFzJU3R3KUVTgu1JwpCh6PMt3ZNMS2F
         uvvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=xNutg0KAusJOiLECrNViEem00yH/hxofmcOk0TEtRMA=;
        b=T9ZYOV2R5TsdRk7uvpwhfWd/eWPyrMujEbsfz5uv2Nx32hRu38j97WYbKqODQ+4hLY
         KxxCd/ArFtjJNa1ly1NJ2FGtoFAGKMtpGufqpRtRhN5oLXohyVSqkjhwaECpCSuv/mXF
         nHJnwaiYAgO4OonyX2qnKgm90dhIW+nTXniejMbheI1QexnsU22tq7gvorukiTUslCnz
         DoSwUDHEBrIZJ+RX80K98QVA7sO3t8I1ygfCwFi5/GW81+0nRhJI3y8R6uui7osO4BbD
         w0hC9eN3htTDTni9GyCZct5fxGZHaPEFvetd7TaNtP6fOYrJzWr4jlvjUL5rUwAC2T3d
         JN+Q==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id g10si2239223edp.138.2020.09.11.14.50.23;
        Fri, 11 Sep 2020 14:50:46 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725893AbgIKVsq (ORCPT <rfc822;epontan@gmail.com> + 99 others);
        Fri, 11 Sep 2020 17:48:46 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36956 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725856AbgIKVso (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Sep 2020 17:48:44 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDE58C061573;
        Fri, 11 Sep 2020 14:48:43 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 597D81366B126;
        Fri, 11 Sep 2020 14:31:56 -0700 (PDT)
Date:   Fri, 11 Sep 2020 14:48:42 -0700 (PDT)
Message-Id: <20200911.144842.1644303060226035755.davem@davemloft.net>
To:     colin.king@canonical.com
Cc:     kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipv6: remove redundant assignment to variable err
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200911103509.22907-1-colin.king@canonical.com>
References: <20200911103509.22907-1-colin.king@canonical.com>
X-Mailer: Mew version 6.8 on Emacs 27.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 11 Sep 2020 14:31:56 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Colin King <colin.king@canonical.com>
Date: Fri, 11 Sep 2020 11:35:09 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable err is being initialized with a value that is never read and
> it is being updated later with a new value. The initialization is redundant
> and can be removed.  Also re-order variable declarations in reverse
> Christmas tree ordering.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.