Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp649536pxk; Fri, 11 Sep 2020 17:36:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4Xu9EDxVK/nfpC4C1YDbUht0fJHnW0OWEaqwE/Cmyu1GMjbkJpkbxTrkOMVVK2h5Oloyw X-Received: by 2002:a17:906:fcc8:: with SMTP id qx8mr4281616ejb.13.1599870983051; Fri, 11 Sep 2020 17:36:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599870983; cv=none; d=google.com; s=arc-20160816; b=TNGdGCfNJuAF3Ri1B53h4eVzA013qXJ7T+Xknl8MMiZqMW8gP1ZPItVX2AvOevHKWP x47i5AL66ZNozACRvq5LA0Q7cWxn0HRIOOGeflFpTiHUMGDDJmkmYax6X/gXKf9ODw4K zarFXywiRWAjn8vIshj4ZGiLdYs1Zn0Q5uBuSMGl3AW6IkVuwPzCstEKbZQFlSsMWq3X iY1MbUdWTxafBXZhjMa1zuijz18DTuElS4QH3iLB6ZlGPkKqW8rtCSy04D4GxkOpBZcZ YNc6l/wAnGhsoTq1pKZ/rIaE/d4tSPkwBhf3vNyIUoSeSNmNaa4wslUXU1LS2gvuMFgB bs/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=SK4IUtg+cbZuAoHV4AaWTSNC9O+QyV9PqddIB+YdRxI=; b=r+7ouLEqN/1C059BNzK54YIbICZIpg1Irb5Xb9HFX0+ENcMSfpNSj4wzJI94p69u8q iLcxUVtdlCZ9uo07O7pPMvZI4rs7CM0AyrYqaHEIdpY9q/tHk2YC/UM+zPrYcgGGXZLE YvdQ2ZSb22Mjxpao4loL4M8I6ax8qB8vUYFKR1BZK+sI9PkNS1xbwmswcTtriIt9Uq4k 1rsbb4juAWzLFknVdyNYho2ROAdcq7gl2T+GM+bgkRwYwTPte5ux+5EuDN/EVJgFuq2e 9dZPKetrA0QwrwPsIuhZ9/KFCls5bvELUtCP/KkPE9yJQIlWjdDrjeJBZX+F+2FqYNZJ ja3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f9si3113778ejl.32.2020.09.11.17.35.59; Fri, 11 Sep 2020 17:36:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725890AbgILAfT (ORCPT + 99 others); Fri, 11 Sep 2020 20:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbgILAfG (ORCPT ); Fri, 11 Sep 2020 20:35:06 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6976EC061757; Fri, 11 Sep 2020 17:35:05 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6E0501226F541; Fri, 11 Sep 2020 17:18:17 -0700 (PDT) Date: Fri, 11 Sep 2020 17:35:03 -0700 (PDT) Message-Id: <20200911.173503.2013046040329976699.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, kuba@kernel.org, vigneshr@ti.com, m-karicheri2@ti.com, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH net-next v3 0/9] net: ethernet: ti: ale: add static configuration From: David Miller In-Reply-To: <20200910202807.17473-1-grygorii.strashko@ti.com> References: <20200910202807.17473-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Fri, 11 Sep 2020 17:18:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Thu, 10 Sep 2020 23:27:58 +0300 > As existing, as newly introduced CPSW ALE versions have differences in > supported features and ALE table formats. Especially it's actual for the > recent AM65x/J721E/J7200 and future AM64x SoCs, which supports more > features like: auto-aging, classifiers, Link aggregation, additional HW > filtering, etc. > > The existing ALE configuration interface is not practical in terms of > adding new features and requires consumers to program a lot static > parameters. And any attempt to add new features will case endless adding > and maintaining different combination of flags and options. Because CPSW > ALE configuration is static and fixed for SoC (or set of SoC), It is > reasonable to add support for static ALE configurations inside ALE module. > > This series introduces static ALE configuration table for different ALE > variants and provides option for consumers to select required ALE > configuration by providing ALE const char *dev_id identifier (Patch 2). > And all existing driver have been switched to use new approach (Patches 3-6). > > After this ALE HW auto-ageing feature can be enabled for AM65x CPSW ALE > variant (Patch 7). > > Finally, Patches 8-9 introduces tables to describe the ALE VLAN entries > fields as the ALE VLAN entries are too much differ between different TI > CPSW ALE versions. So, handling them using flags, defines and get/set > functions are became over-complicated. ... Series applied, thank you.