Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp706347pxk; Fri, 11 Sep 2020 19:57:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwn1tdIFFpbgkqRLAxU+xphiFrMwHGo8LuAPpGeIIsAOJERi4tO39fEFi4b7AkIHdXORQcd X-Received: by 2002:aa7:c61a:: with SMTP id h26mr5814369edq.254.1599879472252; Fri, 11 Sep 2020 19:57:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599879472; cv=none; d=google.com; s=arc-20160816; b=wSms9g9ksssMV/asZ7JhffyszwR3mUF520p+of872Tvv+jbwsYFllzZ7z8+uMJMiRC 0l3k9V/D5TbRXK9eQcYTl7Gbox5mpkgwZVHiYoa6iZeLX0xtErFyF1YlbgOVYGTRptCk g62mR9llD78giH8m96xfvLZHKaImYBUKDnBEtCQAoBOf5dTJNsG0/SbcaBOA+gF26ocE RCumlW6c+7jY/W7Kn7tA5FY+ISMtk3HUajzPcU4umGACaTNFniLphto1Ywn5jMLeEDp8 xlDvt+6JYc8ExjonAe9P9TqrGJacW8cKtRmjU6CFjRwH/Mt0eY+HtJdZV0kTLA1izHyA 6EpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from:ironport-sdr:ironport-sdr; bh=FkZdVIk1W1YPisQeZQb6LmtV5uFsSoMzgHlq6r6kXbk=; b=skFCVwZ97Q1vPSx+KYSUJO3U4jprMLrZVWGbQjiZIKweodsdPdri/uZo7D56qEZ5l2 J3UUGT19j+DPKrIE/HDznqHazEC13l7Ke/pc8gKR83t2OfIdKeUvP9yLI9qcsDhnKwQX 1ORXngyWCyELzL1F4W+abYHeGCl6/ay0g679Z9Ha1z+8pD01z4/kp82FM3aMhYDMHCa4 RdWS96taLfOYLrf3IfyZfnvAboUOaXsFlhXE0fZLw9d3kBmrHyitvoXgNlEEbr8g5uaw SQHa7Tt5fqC+FpJULXt4wSNxgT5CxH5Q1SculJd8HUJ245srnL0I6qjc7eY+PSo/oAId Jp+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz3si2401138ejc.81.2020.09.11.19.57.12; Fri, 11 Sep 2020 19:57:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725792AbgILCze (ORCPT + 99 others); Fri, 11 Sep 2020 22:55:34 -0400 Received: from mga03.intel.com ([134.134.136.65]:57086 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbgILCzd (ORCPT ); Fri, 11 Sep 2020 22:55:33 -0400 IronPort-SDR: SUQYdRRj1tnBuh/6PtvbI5ZkBUzFA26tZOHyf/xP1wCtXBBiuAgpcDCngPZUyKLTKQygqWRa+3 K8wwYIkVrxrw== X-IronPort-AV: E=McAfee;i="6000,8403,9741"; a="158923233" X-IronPort-AV: E=Sophos;i="5.76,418,1592895600"; d="scan'208";a="158923233" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 19:55:27 -0700 IronPort-SDR: vmC/Wd5hOLTiV2dszSt254LC3VzenID53RVvXqFy/H+n6u9sy4umjtG4kNvygYn98l+geOki29 l7U+xqRl/kVA== X-IronPort-AV: E=Sophos;i="5.76,418,1592895600"; d="scan'208";a="450185364" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.212.203]) ([10.254.212.203]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 19:55:25 -0700 From: Lu Baolu Subject: Re: [PATCH V2 2/5] iommu: Add iommu_dma_free_cpu_cached_iovas function To: Christoph Hellwig Cc: baolu.lu@linux.intel.com, Tom Murphy , iommu@lists.linux-foundation.org, Joerg Roedel , David Woodhouse , linux-kernel@vger.kernel.org References: <20200903201839.7327-1-murphyt7@tcd.ie> <20200903201839.7327-3-murphyt7@tcd.ie> <20200909070540.GA28245@infradead.org> Message-ID: <5b146104-34cb-00c5-fecc-0cbc41838682@linux.intel.com> Date: Sat, 12 Sep 2020 10:55:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200909070540.GA28245@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/9 15:05, Christoph Hellwig wrote: >> +static inline void iommu_dma_free_cpu_cached_iovas(unsigned int cpu, >> + struct iommu_domain >> *domain) > > This adds a crazy long line. Which is rather pointless as other > bits of code in the patch use the more compact two tab indentations > for the prototype continuation lines anyway. > Okay. I will use two tabs instead. Best regards, baolu