Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1020363pxk;
        Sat, 12 Sep 2020 08:11:21 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyw2waLZvVKVpCuAOI7//YF4JQVndl5DpmV7ID1wu7I5SjOKgESUlQgPZvDK/RoxYwklNrs
X-Received: by 2002:a17:906:915:: with SMTP id i21mr6252910ejd.113.1599923481680;
        Sat, 12 Sep 2020 08:11:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1599923481; cv=none;
        d=google.com; s=arc-20160816;
        b=Wjd/o18Kms2uUc176Dotc3FUDEWIE7WXPv1wGnfYZ0xxC71MCwMsBzvcvgtm1uYttx
         75lBN6vjt+ANwHrVw11pU9APoxJdBITNxu9QdRdT5z60LOPBc5+lbv+R9R0IHE0djalx
         rXNmeqlaW1U8h5VuybTp9Qnow1AC0idP9rLajbX3Em69QHHyRgrepNXAl7hjjoMcAYKG
         sOizSx2fW/vTOfNlXFf85rwJK/2vNaGbuBDkp481FB0Q9qh4JN1zoQndK98RDtN5N5KJ
         Vbt87EFiT1xTMPdyVHvf8ISDzk95T4H8jNhkxncQhc8mnJOi9m3ZntLrvj6fYoVJ3dlN
         VskA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:dkim-signature;
        bh=ns0xiwrnJendxN6CLtcox2ImSbCLh3e9jw5WmzFYNI8=;
        b=sSl1WLdAEZEOTqD+1RJIc8qJlLb8OKR/Rs6Az8nIuOiE3RynOu/arzz+jugyxpnXEd
         isZcgBte2hYnKgzAE4eSiMpvpXVFfxSpNsE8ylznbhGpfyEwYx4/glW+MopQB4xYSgjK
         nulol7v1NNZDWmrf7ADchO4EsGHtQnnrmJbY5dCUaIPE31W0zwcuw8RNa4cD1GUi3evH
         zKJdx7mMMgCidd8ief9///PNjY4PCrtaj37Kq9G3MZaHBTEmqMf2o2HXl1qzXmjFZhPS
         ftJUpKFaIInLrNLfsHPc1wDA1Q8hP+7IuwxMJSweTBbWGePXfEN2ou2fMlayYhLxgWHN
         mFsw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Fe2I67kf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id v26si3673872edd.443.2020.09.12.08.10.59;
        Sat, 12 Sep 2020 08:11:21 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Fe2I67kf;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725883AbgILPH4 (ORCPT <rfc822;yuvraaj@gmail.com> + 99 others);
        Sat, 12 Sep 2020 11:07:56 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55182 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725850AbgILPHx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 12 Sep 2020 11:07:53 -0400
Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98456C061573;
        Sat, 12 Sep 2020 08:07:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type:
        In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender
        :Reply-To:Content-ID:Content-Description;
        bh=ns0xiwrnJendxN6CLtcox2ImSbCLh3e9jw5WmzFYNI8=; b=Fe2I67kfkTO1R1g0KBKMpXFStG
        gJc/PLRzuGX0cfpNiI1WuH3686jPQc1haYhCarW5LvrlrUuBr10pm0FsC2DKZLyoM1bz/LwGASQ8Z
        eijcOqVQp0I7ZRWAvFqCT9WxYyOLzLSRGscWvL6ZKFDvL7E5BG0PmP0SCK9BRM1djmTVe+b9Fu8As
        behoGvhI9TeXgjpySNZUEAKWkhVejYhxbmZqV7sz2wrEeiYXZKMbRS/3a0JorZU+hxlZF3Sb8zCeF
        luEX4WoUrRmncQb7t9HdIDLpIvlmZ/IddF0H38srMkHHJHou+GSWoVs/tAM6/ONeI01jWJPGsWr7y
        yClvn3RQ==;
Received: from [2601:1c0:6280:3f0::19c2]
        by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux))
        id 1kH77t-0004Fq-M6; Sat, 12 Sep 2020 15:07:41 +0000
Subject: Re: [PATCH v2 08/14] habanalabs/gaudi: add a new IOCTL for NIC
 control operations
To:     Oded Gabbay <oded.gabbay@gmail.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Cc:     SW_Drivers@habana.ai, gregkh@linuxfoundation.org,
        davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
        f.fainelli@gmail.com, Omer Shpigelman <oshpigelman@habana.ai>
References: <20200912144106.11799-1-oded.gabbay@gmail.com>
 <20200912144106.11799-9-oded.gabbay@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <59a861d7-86e5-d806-a195-fd229d27ffb4@infradead.org>
Date:   Sat, 12 Sep 2020 08:07:35 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200912144106.11799-9-oded.gabbay@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 9/12/20 7:41 AM, Oded Gabbay wrote:
> +#define HL_IOCTL_NIC	_IOWR('H', 0x07, struct hl_nic_args)


ioctl numbers ('H') should be documented in
Documentation/userspace-api/ioctl/ioctl-number.rst

Sorry if I missed seeing that. (I scanned quickly.)

thanks.

-- 
~Randy