Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1028731pxk; Sat, 12 Sep 2020 08:28:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2bN1jycXcnetpnpm1H3wt0k1qzBUIbaSVmBVlQVjCzyaGgTedDvQspC7JKWWkNJI2sjfJ X-Received: by 2002:aa7:dbcb:: with SMTP id v11mr8904953edt.351.1599924486730; Sat, 12 Sep 2020 08:28:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599924486; cv=none; d=google.com; s=arc-20160816; b=bBNXWfJoxkcitgg3P4tkoL347KKv3ALhyg+5aZPoBtay+mHSSFYXo9RbsbbbJer730 i64+RLHXRH+JuO04+gMypFHbyZwElBGUlpzZB2gOaPDojY2DsDRYOi51JLGMsAoC0YGF XqlsPP/8XbdkwASqhlDcf8ZmpYXv9YB75AFJVnDmv456m5Vim24SQ1srXZKiFZBWpgI2 eUmaE7FDMpCPz60EP3Kl3vyeTMRE4+lHS5EphT3CTkwkC765aNfdjpv1yUHedQ+kxVf+ l4Zd+Vs6i0qyTb0e5HhdpFaZILlCCJQwV/IEtCn+2Z1NJIxmg5UmBTs80wuy6X91V07n bTtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=SJAWfCenVwOSZWigKxYOq4zYrha5a4ifD+F7e6/X6sc=; b=p1Z+yPgAsjcNpRT9B/JAhSgYj1FCsPmhMSs8yn25slndtvWipd95gIsx8IIQkpQL6/ QlKjTp5ys49hQd7HFsQrp/nbMQTT4DGpaZVcNlSiBz4mh3ZkWtV+s8YVrKv/0WHJr+CX Tb+P4D+lGQmcBld8a0uFwBSPVgYGOZuUDH2Tsj/esju4t40cYKHJnFmTFNiVwscvsR69 1QO5PhzoH7U3yip4aXrCtdigR2kR8OWg5l/j+69Vf02La/JLotaCHq9VXfS/YqQ5sJ0q B3CS76wsvcrvUjUUV0h+Qxt3hggERRLo1jyGTAoSLxJuM40tTkc6h3k1sHFMGLFecaDc s57A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=wWVXm98M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p11si3254028eji.157.2020.09.12.08.27.44; Sat, 12 Sep 2020 08:28:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=wWVXm98M; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725888AbgILPYA (ORCPT + 99 others); Sat, 12 Sep 2020 11:24:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbgILPX6 (ORCPT ); Sat, 12 Sep 2020 11:23:58 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DA2CC061573; Sat, 12 Sep 2020 08:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=SJAWfCenVwOSZWigKxYOq4zYrha5a4ifD+F7e6/X6sc=; b=wWVXm98MBFo/c8XICF6D8TxQjk OchGUiwnsoEutWgjDS9dkBJRMhaR5h03Yqns9vwDljochlttS5481IWk800TaO1reAXlY9FO28RRk waiBRqsOtUyNjkKkjHR8S/8f6prtq6DsH7m00075JPXyfXEGnVxHNUY1yUyW1GmkCE5ZzmCrz5dUA b4oqDEO9Miu3ntMZeRbBjbUIDsb6qbguzpj6OS9FZoKfA+rUMcBtpvd7cl+o/J7jVCJoW4Epdr/zQ WdOdFlkXg7/7dQBXGkBndvalMKq8bdXslyXdmHtZaHgJBOKYP3ZurX3yVdldk4kf2qUI48MIXS6nS Otv8FobA==; Received: from [2601:1c0:6280:3f0::19c2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kH7NW-0004dT-Bl; Sat, 12 Sep 2020 15:23:50 +0000 Subject: Re: [PATCH v2 08/14] habanalabs/gaudi: add a new IOCTL for NIC control operations To: Oded Gabbay Cc: "Linux-Kernel@Vger. Kernel. Org" , netdev@vger.kernel.org, SW_Drivers , Greg Kroah-Hartman , "David S. Miller" , Jakub Kicinski , Andrew Lunn , Florian Fainelli , Omer Shpigelman References: <20200912144106.11799-1-oded.gabbay@gmail.com> <20200912144106.11799-9-oded.gabbay@gmail.com> <59a861d7-86e5-d806-a195-fd229d27ffb4@infradead.org> From: Randy Dunlap Message-ID: Date: Sat, 12 Sep 2020 08:23:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/20 8:19 AM, Oded Gabbay wrote: > On Sat, Sep 12, 2020 at 6:07 PM Randy Dunlap wrote: >> >> Hi, >> >> On 9/12/20 7:41 AM, Oded Gabbay wrote: >>> +#define HL_IOCTL_NIC _IOWR('H', 0x07, struct hl_nic_args) >> >> >> ioctl numbers ('H') should be documented in >> Documentation/userspace-api/ioctl/ioctl-number.rst >> >> Sorry if I missed seeing that. (I scanned quickly.) >> >> thanks. >> >> -- >> ~Randy >> > > Hi Randy, > It is already documented for some time now: > > 'H' 00-0F uapi/misc/habanalabs.h conflict! > > I think you commented on this a few releases ago and I added it then :) Oops. Sorry I missed that. thanks. -- ~Randy