Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1070814pxk; Sat, 12 Sep 2020 09:55:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQMNdJqVIR3ViLxPtaV+8hhgFT4+EKxAOvyR8M6JCyNOMuuTOpGFbUiajz7CTXVzO+Y2dA X-Received: by 2002:aa7:c158:: with SMTP id r24mr8903202edp.61.1599929721371; Sat, 12 Sep 2020 09:55:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599929721; cv=none; d=google.com; s=arc-20160816; b=SINX/KrRjaUJgh15Ar7VT3ynBrl2HjYHtKiCmm8Yw44+wrBWHb5AhpP14hCpJcwn7x mdaR8nZB1Lgh8XC25z29ICSQRV5C/Sn8rqjEf7P3yUj3aIQkuvk7GU2HI6g+R/Ap1VK3 9cx4FXV6y8IzteQGyUnWWqQv9y14rH25/C/krP8FQPqQQyAhzKxLEIB9hsKZ/QZ/euga pqXBVGJkkYTMTtUAnfHj48oZ7AaKcpPknXkCvapwQkcW8QnrF4BgKVpbm334njMYoUUZ j0kxojo6+MK2aqvVvcqseppK5eNTKOKjJR6QkMFl8BRDqcX1F/hIgY10XQx6e5IXuYU7 4m2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=y1i+tRnD/Pinc/Vxe3A21hdWo97zYy4i/YlaOs9ixmA=; b=sRYw01l5HeWXzSvciNxzU51wutTCt0Vrs/asyOvNMK7wrhyYLy+FKgFrxMSyTyNXal YiFI5d8uO+hw2rcHPgAW3zAWwizmJLAUoBE0jdryx/wYsn6G1YrMxfqaUlOL6aNbgd0X lvE2puZ73n93TV7dVN4k6sjNlybQ27EWCZQvY489jYk2e3xbZEb6hb/ChMMdb8lAOnar tdql4XrGQYrWn41aelxjRQZJNQiCsJelVDUvOgJMMmA7BKas5MYgcB8lzHaO1Mv8yn6n qnjq4nUP296u5L76n4mfJz4U2AErWHnk6y30xZpkff0SvXnjrYHQZu1F4I74jNiJuZSg nYKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PTbAcMhC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l19si3831037edq.264.2020.09.12.09.54.48; Sat, 12 Sep 2020 09:55:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PTbAcMhC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725873AbgILQwf (ORCPT + 99 others); Sat, 12 Sep 2020 12:52:35 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:38428 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725846AbgILQw2 (ORCPT ); Sat, 12 Sep 2020 12:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599929547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y1i+tRnD/Pinc/Vxe3A21hdWo97zYy4i/YlaOs9ixmA=; b=PTbAcMhCzngkxJ2KazryplhqTwy74JLXnhhqxIIicEzoOh+b4nHVlAteo5QCwOxsC2hEC5 iUrr8K6zU7PhsUjbcUMLFw7rntMkZER9P6MDqaGsI0ihhbobsI3HB94KEYeXIRl8Qkm3nJ 5TueUIvaW+H5PGf9eyDkARN4XJqGP74= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-Cfr_laRzNjKlrRt-FML29w-1; Sat, 12 Sep 2020 12:52:23 -0400 X-MC-Unique: Cfr_laRzNjKlrRt-FML29w-1 Received: by mail-wm1-f72.google.com with SMTP id u5so1843076wme.3 for ; Sat, 12 Sep 2020 09:52:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y1i+tRnD/Pinc/Vxe3A21hdWo97zYy4i/YlaOs9ixmA=; b=iykj8NqX3w91SBajuZ4m0JuYghCgHags10kSx2Rt58JZMOES5qWYjHzT2FC0vL1qOQ A+POzcMyhkhv7OjMHwy2nRmWE1djwCP1OLrBigZEhn7LiQp5E4T73LtCTqqg5NVUrBb4 /nubG8ozCgnU3Y5kiiT9SjK+m/2u+OtUuKvIelpNJDPdSNegMYfgpNR3m5npY/OXzMqN cweABlNAYPkzSFYfj65jbZQ42QUmaSyeZuyZqcuTgrUk8NR6Qx6VQfGPdbrOa5Lm9UEx 55F6MVMeoRoRNMBTpxMUXZErAiEidSjjrLRpGt9WRlYIikdo81XNvbjo/+BIOZGTWVLe Ogkg== X-Gm-Message-State: AOAM531/etoclA19lCorUbeR+jUYZgxauxj8+oq8/hPnV/W3gCWJT0Ho RzSmMYymMcJXRCdq1mtRk8ggobFNYLDo3B8Eh8oXSOwOUMPebPPzg9Mf7OSIQ3zaLCBly+RhsoV 2mNstw4SCJOBU9WPCWNtnfA98 X-Received: by 2002:a1c:2543:: with SMTP id l64mr7147048wml.96.1599929542005; Sat, 12 Sep 2020 09:52:22 -0700 (PDT) X-Received: by 2002:a1c:2543:: with SMTP id l64mr7147038wml.96.1599929541809; Sat, 12 Sep 2020 09:52:21 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9fd9:16f2:2095:52d7? ([2001:b07:6468:f312:9fd9:16f2:2095:52d7]) by smtp.gmail.com with ESMTPSA id y5sm10962968wmg.21.2020.09.12.09.52.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Sep 2020 09:52:21 -0700 (PDT) Subject: Re: [PATCH v6 04/12] KVM: SVM: Modify intercept_exceptions to generic intercepts To: Babu Moger , vkuznets@redhat.com, sean.j.christopherson@intel.com, jmattson@google.com Cc: wanpengli@tencent.com, kvm@vger.kernel.org, joro@8bytes.org, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, tglx@linutronix.de References: <159985237526.11252.1516487214307300610.stgit@bmoger-ubuntu> <159985250037.11252.1361972528657052410.stgit@bmoger-ubuntu> From: Paolo Bonzini Message-ID: <1654dd89-2f15-62b6-d3a7-53f3ec422dd0@redhat.com> Date: Sat, 12 Sep 2020 18:52:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <159985250037.11252.1361972528657052410.stgit@bmoger-ubuntu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/20 21:28, Babu Moger wrote: > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index 1a5f3908b388..11892e86cb39 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -1003,11 +1003,11 @@ static void init_vmcb(struct vcpu_svm *svm) > > set_dr_intercepts(svm); > > - set_exception_intercept(svm, PF_VECTOR); > - set_exception_intercept(svm, UD_VECTOR); > - set_exception_intercept(svm, MC_VECTOR); > - set_exception_intercept(svm, AC_VECTOR); > - set_exception_intercept(svm, DB_VECTOR); > + set_exception_intercept(svm, INTERCEPT_PF_VECTOR); > + set_exception_intercept(svm, INTERCEPT_UD_VECTOR); > + set_exception_intercept(svm, INTERCEPT_MC_VECTOR); > + set_exception_intercept(svm, INTERCEPT_AC_VECTOR); > + set_exception_intercept(svm, INTERCEPT_DB_VECTOR); I think these should take a vector instead, and add 64 in the functions. Paolo