Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 12 Sep 2020 18:22:19 -0700 (PDT)
Message-Id: <20200912.182219.1013721666435098048.davem@davemloft.net>
To:     luojiaxing@huawei.com
Cc:     kuba@kernel.org, idos@mellanox.com, ogerlitz@mellanox.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com
Subject: Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value
 to ring_cons but not used it anymore in mlx4_en_xmit()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1599898095-10712-1-git-send-email-luojiaxing@huawei.com>
References: <1599898095-10712-1-git-send-email-luojiaxing@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Luo Jiaxing <luojiaxing@huawei.com>
Date: Sat, 12 Sep 2020 16:08:15 +0800

> We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will
> cause a warning when build the kernel. And after checking the commit record
> of this function, we found that it was introduced by a previous patch.
> 
> So, We delete this redundant assignment code.
> 
> Fixes: 488a9b48e398 ("net/mlx4_en: Wake TX queues only when there's enough room")
> 
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>

Looks good, applied, thanks.