Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <641dfe3b-1de8-97ea-eac7-89d81846eab3@web.de>
In-Reply-To: <641dfe3b-1de8-97ea-eac7-89d81846eab3@web.de>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Sun, 13 Sep 2020 18:31:08 +0530
Message-ID: <CAFqt6zYA4srnsGx+OzrzVuzasOvUQR+dN0nmVZcv1zVeotxKUA@mail.gmail.com>
Subject: Re: [PATCH] tee/tee_shm.c: Fix error handling path
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org,
        Jens Wiklander <jens.wiklander@linaro.org>,
        John Hubbard <jhubbard@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 13, 2020 at 2:00 PM Markus Elfring <Markus.Elfring@web.de> wrot=
e:
>
> > When shm->num_pages <=3D 0, we should avoid calling
> > release_registered_pages() in error handling path.
>
> * Would an imperative wording become helpful for the change description?
>
> * I suggest to add the tag =E2=80=9CFixes=E2=80=9D to the commit message.

Sure. Will address both in v2.
>
> Regards,
> Markus