Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1631410pxk; Sun, 13 Sep 2020 10:01:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfH63xWrjS15ulcf7RFBLIiLfRqXoKfkzMy8WxBc9g9bJ1FcT6Wzol+lSGIA6hHwUcf/cm X-Received: by 2002:a17:906:fcc7:: with SMTP id qx7mr11506884ejb.254.1600016501435; Sun, 13 Sep 2020 10:01:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600016501; cv=none; d=google.com; s=arc-20160816; b=tb3PRX4ynv36Q7K9ROOZXbToPZjnnSEvyNM6tzxLFOFJ4KnJjljsXUhk+oIcnrcH0w ZmCmX1adwiE0cjWUzEAnbj+v6YGi6b6XxgZuV5soNf/N0g/6dW4OTU3LPXbwzCV4rRiH IRbzD0UTugS1+dhBT6/YS9Sw57kR4Z/0wsU02y7evyyJdFEvmen02Mjq4T6fxVkXo2Cn 7PAba/b7UK0DYax8PZd4e0fyyz04odWMBbKOOFULgVhuH7303C4mxaqKQM2QRYD83tn2 86a0vENUr1H8hQvjteVyumva/jYVD4uKERyqUxX9CRHjrH1+YiugQP+uHXzZTmsI548R tGZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Omc5GUviZXmY9Fz9BCq4ZAvwSSBNWz0aHFjh7JiCaqY=; b=LPkoVorlMSeD1wB47CHlTQefddYdAkJEu1r6apK/O4Wa/2EZYUPFa+fwebDhZ5qIN+ A3WSoxigXAOIPz555u4UvkiHWZxKwkmXOiML8/ZfueWIqYMgooGm3eBSfYtvQcgRdcBL +1Ep7UOJ9tAK20KIeBO6wG+2akld04wU/1hC85Dyw1yaNMNBtX3BWW1SvA5HeRAkdAbD 9cFNwl+W76VeefWSzav05zWfIjN7Cu1ZKpWHw/S0KLBPIce5uz2Tm51BUqf3fKX/etLM GZf2lxISDDyCdlAfIKp8xMBQLoQs02bWhWezKtp5WSoJ78fbJiz0o9/8q4YWZ3g7Ro/+ 85FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Cq2i5Du9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a16si5528918eje.544.2020.09.13.10.01.18; Sun, 13 Sep 2020 10:01:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Cq2i5Du9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725954AbgIMRAH (ORCPT + 99 others); Sun, 13 Sep 2020 13:00:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbgIMRAA (ORCPT ); Sun, 13 Sep 2020 13:00:00 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF83EC06174A; Sun, 13 Sep 2020 09:59:59 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id l191so9599751pgd.5; Sun, 13 Sep 2020 09:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Omc5GUviZXmY9Fz9BCq4ZAvwSSBNWz0aHFjh7JiCaqY=; b=Cq2i5Du97qqZ9zymjDh//gocDk6OuGx4PmVS3Xx72RkkIF08zJzcdSB8CQ46x7/Uqq Ptidw2bGkNuKFvkBDhwuhJQ29+9mwuhGmw65W1jMa022tWLkCqZUtOhd7qB9IipVgIl8 49BSGyKnPgUsu/iSpU5dR3TRfK5kNTkuYDjPGkNw1dcgdSFPGhjEeNHclnvicgz57MUN 2IAlSqknJwKkUc+oh3deU2H4h1QImvn14jwvKz1gyP1C2oc1fudWqHc3FYzVcOB5dd1O Z24zAsZef7oOKuwpLcCN6i0T86OvaYh3r5Xk2WYoA02WxQNimvtltr5lAqM5Fw7WLSC1 CZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Omc5GUviZXmY9Fz9BCq4ZAvwSSBNWz0aHFjh7JiCaqY=; b=pO1QGTokn9fP6nzvZsKiomD3MN3rhihWCXXceBbESWS1w+Vdx8Zr2ECrdDd2Dxg5TA sugMQUdS7XIbLG4NhF6ouPuZFnV7RTbhHJvkbSNUg9qhH72yFtvt4Jv+dVnhgtPHPjVe yz3FMoP3rAxzGY7UArfynxdyNJwX6ljgcbtPiW3wnllg9LmU14bECjpyQqBBJm8SMs6x rUMHP6OfA4Tt9IhE1uYJ4ISjaC5oclKT8aD2j2gqw+d6QpkwoBg3Mxpzam16xdNsjExo 3dk1ncg9XqfjS1II1pkIe+vRMhwHYQ/c8QO+SGFXeoxTuZiyeCeKVKl4cm9P0sEXm0kQ VtzQ== X-Gm-Message-State: AOAM5320kHECuhHHqveq/WaydNMxR8gCwGOX4N48vAdb/V/TKCYPDHY8 xm9DloufAHxi9VthI2vRDDY= X-Received: by 2002:a63:a05:: with SMTP id 5mr4091629pgk.140.1600016399059; Sun, 13 Sep 2020 09:59:59 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id s8sm221929pjn.10.2020.09.13.09.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 09:59:58 -0700 (PDT) Date: Sun, 13 Sep 2020 09:59:56 -0700 From: Dmitry Torokhov To: Michael Kelley Cc: Boqun Feng , "linux-hyperv@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Jiri Kosina , Benjamin Tissoires , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , "will@kernel.org" , "ardb@kernel.org" , "arnd@arndb.de" , "catalin.marinas@arm.com" , "Mark.Rutland@arm.com" , "maz@kernel.org" Subject: Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages Message-ID: <20200913165956.GG1665100@dtor-ws> References: <20200910143455.109293-1-boqun.feng@gmail.com> <20200910143455.109293-9-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2020 at 07:37:23PM +0000, Michael Kelley wrote: > From: Boqun Feng Sent: Thursday, September 10, 2020 7:35 AM > > > > > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > > least 2 * PAGE_SIZE: one page for the header and at least one page of > > the data part (because of the alignment requirement for double mapping). > > > > So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when > > using vmbus_open() to establish the vmbus connection. > > > > Signed-off-by: Boqun Feng > > --- > > drivers/input/serio/hyperv-keyboard.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Michael Kelley Acked-by: Dmitry Torokhov Please feel free to merge with the rest of the patches through whatever tree they will go in. Thanks. -- Dmitry