Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1871323pxk; Sun, 13 Sep 2020 20:20:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3blLbKAc5PKlGz/glFOcRIpwWdw8oRIhKSwk9+HpXdIQ5vgbakfGICFugQ1DrX2Ca5Itj X-Received: by 2002:a17:907:2173:: with SMTP id rl19mr12434245ejb.514.1600053614736; Sun, 13 Sep 2020 20:20:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600053614; cv=none; d=google.com; s=arc-20160816; b=CSwOIwoXWQ1jZGUd4v7oyZSrpMJ5L25qt1jZfW5Bw0H1IJpvxXtvSQf2puQfENWMCn rRM2mtnoJKd00xUl9Hyb9txYBgx7QBwhZxVA0WjeO0JkR0gLkvzQRkYExqnJ9HFiaHEF BxODOqEeelUN7WxHH9SBbM4mOdzNFUeZDgUqYD2iYmpuGabMFEKRd8AtoXj7inY4Pakc oNTFCpRgAFyE0c9CTDCOxN4ZNYiAwrKIQbEH9uWFwlpLqXAEFvi3fkXemzFvRozRfyWH V5n46vYszs9mCuyxdSFhjNbyES/9MfvKaH7XQ8wmd2lxbo5phoRxifqtvwyB9bQfUWXY ocew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=ENqcd7o4FasolxiCqdL87OAojxosxxx21AdMeQtNCN0=; b=oWh1iQUkJX0P8FBvliJl+LJ0DjQvWYsXxw3iR3xQ45+Pu0wv74jQeUYzjbypr/z1GH +Tt7ymp/DDFB1tuWd8CPWxThc5gXs+F8ZqHi9y4hMBzM63YZk/GXdQ9xGLaJ8iR1jA/s nUE6XTg5n4uFxCSqtWw5E3X15ujH/bGihmXSUA0RPCDH2J3+AyRCyGVD5uDH5K2uC7hX DN3csYKOuVlFkEh4sGcKRNVUNgq7mFj87EuwmzQjHahdm95UmF4Ivtqp3eu3cXngouo9 dnvH1mzmOib4ws8qonbIdDInPLEtbTBqzQsnjZ5H5dz01i4CglUWa6Fz3dotxqcJby41 NNCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh9si6127147ejb.613.2020.09.13.20.19.51; Sun, 13 Sep 2020 20:20:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725996AbgINDS7 (ORCPT + 99 others); Sun, 13 Sep 2020 23:18:59 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:12244 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725965AbgINDS6 (ORCPT ); Sun, 13 Sep 2020 23:18:58 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8AAEA707EE2375575932; Mon, 14 Sep 2020 11:18:55 +0800 (CST) Received: from [10.174.178.86] (10.174.178.86) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 14 Sep 2020 11:18:53 +0800 Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 To: Muchun Song , Chris Down CC: , Johannes Weiner , , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Cgroups , , LKML , Linux Memory Management List , kernel test robot References: <20200913070010.44053-1-songmuchun@bytedance.com> <20200913170913.GB2239582@chrisdown.name> From: Zefan Li Message-ID: <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> Date: Mon, 14 Sep 2020 11:18:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.86] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/9/14 11:10, Muchun Song wrote: > On Mon, Sep 14, 2020 at 1:09 AM Chris Down wrote: >> >> Muchun Song writes: >>> In the cgroup v1, we have a numa_stat interface. This is useful for >>> providing visibility into the numa locality information within an >>> memcg since the pages are allowed to be allocated from any physical >>> node. One of the use cases is evaluating application performance by >>> combining this information with the application's CPU allocation. >>> But the cgroup v2 does not. So this patch adds the missing information. >>> >>> Signed-off-by: Muchun Song >>> Suggested-by: Shakeel Butt >>> Reported-by: kernel test robot >> >> This is a feature patch, why does this have LKP's Reported-by? > > In the v2 version, the kernel test robot reported a compiler error > on the powerpc architecture. So I added that. Thanks. > You should remove this reported-by, and then add v2->v3 changelog: ...original changelog... v3: - fixed something reported by test rebot