Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
AI-Spam-Status: Not processed
Subject: Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT_RAM
To:     Youling Tang <tangyouling@loongson.cn>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1599875955-9207-1-git-send-email-tangyouling@loongson.cn>
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
Message-ID: <f2349dc3-8086-64ee-e2d7-7a69afac6623@flygoat.com>
Date:   Mon, 14 Sep 2020 12:32:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <1599875955-9207-1-git-send-email-tangyouling@loongson.cn>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


?? 2020/9/12 9:59, Youling Tang д??:
> Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
> the BOOT_MEM_INIT_RAM unused, remove it.
>
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> ---
>   arch/mips/include/asm/bootinfo.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
> index 147c932..39196ae 100644
> --- a/arch/mips/include/asm/bootinfo.h
> +++ b/arch/mips/include/asm/bootinfo.h
> @@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
>   #define BOOT_MEM_RAM		1
>   #define BOOT_MEM_ROM_DATA	2
>   #define BOOT_MEM_RESERVED	3
> -#define BOOT_MEM_INIT_RAM	4

If you're willing to remove that you'd better turn the memtype struct
into a enum.

Btw: It seems you've done a lot of minor clean-up works recently,
if you'd like to I think you can try to turn all the platforms into memblock
and remove all these gules between memblock and legacy code.

Thanks.

- Jiaxun

>   #define BOOT_MEM_NOMAP		5
>   
>   extern void add_memory_region(phys_addr_t start, phys_addr_t size, long type);