Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1918197pxk; Sun, 13 Sep 2020 22:33:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzfLDoNggVwbPjLTnm46cCXpJPOS+gowj6xuNIklM75HtT6V5CwPJnvEjC+RtOWUCBH7279 X-Received: by 2002:aa7:d4d0:: with SMTP id t16mr15536518edr.83.1600061608711; Sun, 13 Sep 2020 22:33:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600061608; cv=none; d=google.com; s=arc-20160816; b=vL25oXFwd8/YVtLLHBRVVhbdwU7SZvYZC+xAQ0pV6vKviapxuSzq1QluXTMlndXZIQ 18fU26MVZ3C2BFBBQ6wozsngfmHo992x6NxQkI4is4HRLJvb8JohzFq4juQVFbNs6Nrp Y++C1YUQUelxVrwQCYCMkknj28oY3PhJG0AeX7kxOlWTzUmc96XYvQ2Z3DAYhl5OKlJ0 S///+JnVLlz6xOHp9brWpKtqj3L4PLjF/XlHZ+pZgNtChwq7xW+rHmOs2nOPqzOSfBmz lyCaC75Oxv0MAuK9Yo3wSmEan13iVSEEpwPEP5AqzEny0afYQAxMkaiK4iSnJHAGclWn 4ziA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=cdG88bDail1ztsGpYD4RoppUu2eGbTbXmHUsH5t/DJU=; b=lIJ8ETW4eEgH0jXlMt71Ja7C/5Hoomdei0x0jdF3u7VdNSLROed4duiM6QAgUmtlh/ RC5Bi3DezQBDmg58whyhiLLDY+NGwWx6wHeiHLFZuPDHepTAuJIsPaTNzUP3WJJkUGJE 0PAIpk30Q3VaqwmfIjnDarqi1ftoFoaQwyPoGGa4wRBABBdc6VT20QD5Q6wCRpabEjVL y9biGTfKBgzdrw1shYvweLw1ww2ooUhEaNaMS3dhySBHK0NtIVLnLc4gJMC/aNchNkYy Pe/9RGJXqlIBWGOrLrN8v4MExWmf6GAtbPRAl+GBZqhHCIBfijD92/3SThmZQes3fi4A lSFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs1si7342598edb.6.2020.09.13.22.33.07; Sun, 13 Sep 2020 22:33:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726078AbgINFcE (ORCPT + 99 others); Mon, 14 Sep 2020 01:32:04 -0400 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:51727 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgINFcE (ORCPT ); Mon, 14 Sep 2020 01:32:04 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R791e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0U8psLXS_1600061520; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0U8psLXS_1600061520) by smtp.aliyun-inc.com(127.0.0.1); Mon, 14 Sep 2020 13:32:00 +0800 Date: Mon, 14 Sep 2020 13:32:00 +0800 From: Baolin Wang To: tj@kernel.org, axboe@kernel.dk Cc: baolin.wang7@gmail.com, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Some improvements for blk-throttle Message-ID: <20200914053200.GA128318@VM20190228-100.tbsite.net> Reply-To: Baolin Wang References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun and Jens, On Mon, Sep 07, 2020 at 04:10:12PM +0800, Baolin Wang wrote: > Hi All, > > This patch set did some clean-ups, as well as removing some unnecessary > bps/iops limitation calculation when checking if can dispatch a bio or > not for a tg. Please help to review. Thanks. Any comments for this patch set? > > Baolin Wang (5): > blk-throttle: Fix some comments' typos > blk-throttle: Use readable READ/WRITE macros > blk-throttle: Define readable macros instead of static variables > blk-throttle: Avoid calculating bps/iops limitation repeatedly > blk-throttle: Avoid checking bps/iops limitation if bps or iops is > unlimited > > block/blk-throttle.c | 59 ++++++++++++++++++++++++++++++++-------------------- > 1 file changed, 36 insertions(+), 23 deletions(-) > > -- > 1.8.3.1