Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1933440pxk; Sun, 13 Sep 2020 23:14:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkX1ojUG7edljUpVqSNp8hNbrsiW9fKLsbZTrrs6bvE0cEhvDsb5Oy0wtPdqxH2uu6+KvT X-Received: by 2002:a17:906:2a17:: with SMTP id j23mr12851234eje.146.1600064072625; Sun, 13 Sep 2020 23:14:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600064072; cv=none; d=google.com; s=arc-20160816; b=ejqEiliyKwXLhtWRMG2n7gXQcWBLMhsRqlf7jxf9fiD281gu7h9CZJh68BAB2Nn1i6 EJknc7sOO/Nf9apt2R3clowJbCY3m+LAwtLS1bd8tH7mDN/HFdPqnI56wYqgMnZ5J9S3 d+0BtvIgrtMbquhDmogdL0xHSxZYEsCrRLRap6Flk6yR8p1HDxhUi7/d0UkTNVgQqtHt pYe5cYlu1o1PfS6m7RvUWRI1etRb5btWNJACeKKLQ3AeUZgaHxFVQXUcVcXBvkn9DsaT Ed3A90dpclLEWutg9EnB/PHZI10aYl7htNC8BYCH84y+Qg4VYALuMSmD2NUmizpap8PQ ScGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=a64F8CCn4Ox6rgMtohvHKEVcwtBfogLrv4adYQRHpRM=; b=bD2y7faq+d6Yyh0LPhFasWzQ+kf+by326uIx7RC8QRWj+hOZAi6WQbVB91dGHuAEe4 swgiAihVIAj4MkWtiMW4s5cAOpqp6+O0CCvPXjb6aKhHT14Lf5W5aHSEeLDJZyd9lObz nfzL/0xBvinh/Iy1A/YSuyrDYep9ne+VuUA5bdwgaYgiYD5gR3NMxH9EmdKt6++HTiHE dIlDszShBApKdEgUNTzfQF28RpbPdZPLEOpf4clBgulPqRomiEALXtDjABAJGprd5Isz 9BajI01sh7hBN2A1zlKBjzocCJOUw7udOAGDQew0Gq2PmZR4pc7vTmD3KR76ZqQwx9Mk GV3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gs20si6551467ejb.230.2020.09.13.23.14.10; Sun, 13 Sep 2020 23:14:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726066AbgINGNg (ORCPT + 99 others); Mon, 14 Sep 2020 02:13:36 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:11827 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726027AbgINGNg (ORCPT ); Mon, 14 Sep 2020 02:13:36 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3487B76404C4321E2EA7; Mon, 14 Sep 2020 14:13:32 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Mon, 14 Sep 2020 14:13:23 +0800 From: Qinglang Miao To: Benjamin Herrenschmidt CC: , , "Qinglang Miao" Subject: [PATCH -next] macintosh: windfarm: use for_each_child_of_node() macro Date: Mon, 14 Sep 2020 14:14:11 +0800 Message-ID: <20200914061411.3356-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use for_each_child_of_node() macro instead of open coding it. Signed-off-by: Qinglang Miao --- drivers/macintosh/windfarm_smu_sat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/macintosh/windfarm_smu_sat.c b/drivers/macintosh/windfarm_smu_sat.c index cb75dc035..e46e1153a 100644 --- a/drivers/macintosh/windfarm_smu_sat.c +++ b/drivers/macintosh/windfarm_smu_sat.c @@ -216,8 +216,7 @@ static int wf_sat_probe(struct i2c_client *client, vsens[0] = vsens[1] = -1; isens[0] = isens[1] = -1; - child = NULL; - while ((child = of_get_next_child(dev, child)) != NULL) { + for_each_child_of_node(dev, child) { reg = of_get_property(child, "reg", NULL); loc = of_get_property(child, "location", NULL); if (reg == NULL || loc == NULL) -- 2.23.0