Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200903000658.89944-1-xie.he.0141@gmail.com> <20200904151441.27c97d80@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <CAJht_EN+=WTuduvm43_Lq=XWL78AcF5q6Zoyg8S5fao_udL=+Q@mail.gmail.com> <m3v9ghgc97.fsf@t19.piap.pl>
In-Reply-To: <m3v9ghgc97.fsf@t19.piap.pl>
From:   Xie He <xie.he.0141@gmail.com>
Date:   Sun, 13 Sep 2020 23:18:46 -0700
Message-ID: <CAJht_ENMtrJouSazq3yL7JUS+Hwv4mjtxrcpqxOrc+6vMUVM=w@mail.gmail.com>
Subject: Re: [PATCH net v2] drivers/net/wan/hdlc_fr: Add needed_headroom for
 PVC devices
To:     =?UTF-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
Cc:     Jakub Kicinski <kuba@kernel.org>, Krzysztof Halasa <khc@pm.waw.pl>,
        "David S. Miller" <davem@davemloft.net>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Martin Schiller <ms@dev.tdt.de>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 13, 2020 at 10:26 PM Krzysztof Ha=C5=82asa <khalasa@piap.pl> wr=
ote:
>
> Xie He <xie.he.0141@gmail.com> writes:
>
> > The HDLC device is not actually prepending any header when it is used
> > with this driver. When the PVC device has prepended its header and
> > handed over the skb to the HDLC device, the HDLC device just hands it
> > over to the hardware driver for transmission without prepending any
> > header.
>
> That's correct. IIRC:
> - Cisco and PPP modes add 4 bytes
> - Frame Relay adds 4 (specific protocols - mostly IPv4) or 10 (general
>   case) bytes. There is that pvcX->hdlcX transition which adds nothing
>   (the header is already in place when the packet leaves pvcX device).
> - Raw mode adds nothing (IPv4 only, though it could be modified for
>   both IPv4/v6 easily)
> - Ethernet (hdlc_raw_eth.c) adds normal Ethernet header.

Thank you for the nice summary!

I just realized that we can indeed support both IPv4/v6 in hdlc_raw.
Both IPv4 and v6 packets have a version field in the header, so we can
use it to distinguish v4 and v6 packets on receiving. We can introduce
it as a new feature some time.