Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1951086pxk; Sun, 13 Sep 2020 23:59:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4ZjgdfRTtwObDBE09u9pMZ3ApdTAENFJCGvADBv/GnGb8L2fQvqk+F2ojmJCJNLDR+cVO X-Received: by 2002:a50:e807:: with SMTP id e7mr16053345edn.84.1600066780240; Sun, 13 Sep 2020 23:59:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600066780; cv=none; d=google.com; s=arc-20160816; b=CKTFAEHHoAvB2Tkyf/EiH/r4N2i0acIxJykRa700eoq1SQRH5yeX1DOD9POK6S62Vd IW83mHrBAX+GDRTawnCA4Guvu/OQH4bf+56qRYLj4LGfq5BwsJj22UMjLJjzbgPils3q OUhNd1XhpPT/PLRjoQG+3xVPmOtf4XiaEPG9gaO2YiFPMojsMR5yx98rwuTpgWt33U7T 6yO2VgAu7OpXfuTeGWnqjTOv9TVZt2DEMcFycTO9S2PDiY6t5hbuO02mjKJKcsTUWtdE 7I0jyRXJQ7Utk0qaRpNOufzY4wjNOTyFJeicnKQ7NaLL4KSx/Sbgl1jJrz2hlsOu8ZqI 2xFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=M3lztHJyBuAkCA+eiG2skA0kVPp/UdnzOX3/EVQJ58M=; b=LruTcutMq+X56mb9m0SrkecUiSmF2p0RCVtI1NXu2XqKr5KpPXc2AhW7nhE5u4G9px KyphUlhJ13oTuGuankBYj4/Ahz5lsGO8l0LaRAMlqZeLahG4imAcrYhNvclzQoxA2gKU /OSjSuitM6wir5ndQgQSM6ltf70Bmwzqrgoo37osg03+7Fsa1jyuxWVqFFinqFmxNBOd UwUsHBw9/AoYmez0aPZq0/bt3P7xMWF2M2gD9kN2rnEaaCAli8CUjXQcXOBU1GXk/vyi rkPoZOX4sfHD/PddKMba/OJxF1W5mk9407STZamcUWdoKWjiVycoqgN0ko4I5scMLiUa nTCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c2eeTVMq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f14si6163127ejq.98.2020.09.13.23.59.18; Sun, 13 Sep 2020 23:59:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=c2eeTVMq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726130AbgING5K (ORCPT + 99 others); Mon, 14 Sep 2020 02:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbgING5J (ORCPT ); Mon, 14 Sep 2020 02:57:09 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C2F4C06174A; Sun, 13 Sep 2020 23:57:08 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id h17so13974146otr.1; Sun, 13 Sep 2020 23:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M3lztHJyBuAkCA+eiG2skA0kVPp/UdnzOX3/EVQJ58M=; b=c2eeTVMqM6vwsjE4/Y+k756O2OHzXBtbHmd5vYI//w4CLJZNFUkz8lVfV3xQ1bEE34 FJ8JWGiROaUIKI+/h72MGlLjda1nINgvtpkmgxUVWulRHvP33VRQBljFsYIqdwfBGc9A HlY7j+sOYdFlRFRuG4i92kBMsy4oyGVcKcmH9diiROwBqM/bj2DQQMuYKUw6ZWWXr3VG KTxJRA/ODSsBp9+A4gKUSef78+TDlHUMJ37RpbVcruRZ8mbprz9hptoWzLKQrBl4nflC CU05PnEfIEGwyNTKnQ2YdDXB2rxlVkyqQAwmjEcVWU3kybFoTOAftDnc9ClE6dbyeCiw syvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M3lztHJyBuAkCA+eiG2skA0kVPp/UdnzOX3/EVQJ58M=; b=R6kWJioILCQc1glGU+tEGYfbEYmGgQWgqLa05GvrejxHdT2llrjwY3/mf3PzvWh2Bb 16D7DFOpPm+AyAOwDiXvWvZtr5Fo07z5TK21i5FHff6J2sYc4z6Xq6FeQABSroJt9FNB cBnN1BIAZHio+9fQVfF5l0Jy8X0bUzk9Hma11Qd7IV92FIES7hx1G39ZTg6+KwH3yKwO EjFwx2L0/0Zv8OZoiBjfuMrfy0IWarzObiQUlHzX6dxJNC4K5KFcTCuk9V3WA928lO13 4tp7yepCvEvF8q8tu/VSsnvZ4ijeJL3OobsIbAmrbjcy6BlT4nIYi5Fz0A6gx1dnkOi5 8P7Q== X-Gm-Message-State: AOAM5338aLI5Aeanj/P5vqdny1FwKgo0KGXbJKJlFCfL/OWXcTieylaY VNfCJrbQMgpQLJ6/HzzfL8yhuyZsTidX1zhDSq4= X-Received: by 2002:a05:6830:10c4:: with SMTP id z4mr7613377oto.254.1600066623740; Sun, 13 Sep 2020 23:57:03 -0700 (PDT) MIME-Version: 1.0 References: <1599620119-12971-1-git-send-email-wanpengli@tencent.com> <87eenbmjo4.fsf@vitty.brq.redhat.com> In-Reply-To: From: Wanpeng Li Date: Mon, 14 Sep 2020 14:56:52 +0800 Message-ID: Subject: Re: [PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run() To: Paolo Bonzini Cc: Vitaly Kuznetsov , LKML , kvm , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel , "Paul K ." Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Sep 2020 at 14:20, Paolo Bonzini wrote: > > On 09/09/20 10:47, Wanpeng Li wrote: > >> One more thing: > >> > >> VMX version does > >> > >> vmx_complete_interrupts(vmx); > >> if (is_guest_mode(vcpu)) > >> return EXIT_FASTPATH_NONE; > >> > >> and on SVM we analyze is_guest_mode() inside > >> svm_exit_handlers_fastpath() - should we also change that for > >> conformity? > > > > Agreed, will do in v2. > > Please just send an incremental patch. Thanks! Just sent out a patch to do it. :) Wanpeng