Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] extcon: axp288: use module_platform_driver to
 simplify the code
To:     Liu Shixin <liushixin2@huawei.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Chen-Yu Tsai <wens@csie.org>
Cc:     linux-kernel@vger.kernel.org
References: <20200914065400.3726302-1-liushixin2@huawei.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <085e3e4a-863c-39e4-6028-1d87fff70800@redhat.com>
Date:   Mon, 14 Sep 2020 09:35:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200914065400.3726302-1-liushixin2@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 9/14/20 8:54 AM, Liu Shixin wrote:
> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
> 
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

Thank you for the cleanup, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>   drivers/extcon/extcon-axp288.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 525345367260..fdb31954cf2b 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -491,18 +491,7 @@ static struct platform_driver axp288_extcon_driver = {
>   		.pm = &axp288_extcon_pm_ops,
>   	},
>   };
> -
> -static int __init axp288_extcon_init(void)
> -{
> -	return platform_driver_register(&axp288_extcon_driver);
> -}
> -module_init(axp288_extcon_init);
> -
> -static void __exit axp288_extcon_exit(void)
> -{
> -	platform_driver_unregister(&axp288_extcon_driver);
> -}
> -module_exit(axp288_extcon_exit);
> +module_platform_driver(axp288_extcon_driver);
>   
>   MODULE_AUTHOR("Ramakrishna Pallala <ramakrishna.pallala@intel.com>");
>   MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
>