Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4 2/3] media: i2c: ov772x: Add support for BT656 mode
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Jacopo Mondi <jacopo@jmondi.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org,
        Biju Das <biju.das.jz@bp.renesas.com>,
        Prabhakar <prabhakar.csengg@gmail.com>
References: <20200913184247.618-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20200913184247.618-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
From:   Sergei Shtylyov <sergei.shtylyov@gmail.com>
Organization: Brain-dead Software
Message-ID: <bb9fcd11-21d9-1ce0-4247-a5f80d836da7@gmail.com>
Date:   Mon, 14 Sep 2020 10:55:48 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200913184247.618-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello!

On 13.09.2020 21:42, Lad Prabhakar wrote:

> Add support to read the bus-type for V4L2_MBUS_BT656 and
> enable BT656 mode in the sensor if needed.

    Isn't it called BT.656?

> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>   drivers/media/i2c/ov772x.c | 27 +++++++++++++++++++++------
>   1 file changed, 21 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> index 551082aa7026..edd7c4c22225 100644
> --- a/drivers/media/i2c/ov772x.c
> +++ b/drivers/media/i2c/ov772x.c
[...]
> @@ -1427,16 +1434,24 @@ static int ov772x_probe(struct i2c_client *client)
>   		goto error_clk_put;
>   	}
>   
> -	bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
> +	bus_cfg = (struct v4l2_fwnode_endpoint)
> +		  { .bus_type = V4L2_MBUS_BT656 };
>   	ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
>   	priv->bus_type = bus_cfg.bus_type;
>   	v4l2_fwnode_endpoint_free(&bus_cfg);
>   	if (ret) {
> -		/* For backward compatibility with the existing DT where
> -		 * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL
> -		 */
> -		priv->bus_type = V4L2_MBUS_PARALLEL;
> -		dev_notice(&client->dev, "Falling back to V4L2_MBUS_PARALLEL mode\n");
> +		bus_cfg.bus_type = V4L2_MBUS_PARALLEL;
> +		ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
> +		priv->bus_type = bus_cfg.bus_type;
> +		v4l2_fwnode_endpoint_free(&bus_cfg);
> +		if (ret) {
> +			/* For backward compatibility with the existing DT where
> +			 * bus-type isnt specified fallback to V4L2_MBUS_PARALLEL
                                     ^^^^ isn't
    Could be fixed, while at it?

> +			 */
> +			priv->bus_type = V4L2_MBUS_PARALLEL;
> +			dev_notice(&client->dev,
> +				   "Falling back to V4L2_MBUS_PARALLEL mode\n");
> +		}
>   	}
>   
>   	ret = ov772x_video_probe(priv);

MBR, Sergei