Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200914065402.3726408-1-liushixin2@huawei.com>
In-Reply-To: <20200914065402.3726408-1-liushixin2@huawei.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Mon, 14 Sep 2020 16:12:19 +0800
Message-ID: <CAAfSe-uvy4Fz0RdcfWmJtyB7K_0LBD5_Dm8HFLaiV7aQ2HP_eQ@mail.gmail.com>
Subject: Re: [PATCH -next] pinctrl: sprd: use module_platform_driver to
 simplify the code
To:     Liu Shixin <liushixin2@huawei.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        linux-gpio@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 14 Sep 2020 at 14:32, Liu Shixin <liushixin2@huawei.com> wrote:
>
> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

Thanks,
Chunyan

> ---
>  drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c b/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c
> index 06c8671b40e7..d14f382f2392 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c
> @@ -946,18 +946,7 @@ static struct platform_driver sprd_pinctrl_driver = {
>         .remove = sprd_pinctrl_remove,
>         .shutdown = sprd_pinctrl_shutdown,
>  };
> -
> -static int sprd_pinctrl_init(void)
> -{
> -       return platform_driver_register(&sprd_pinctrl_driver);
> -}
> -module_init(sprd_pinctrl_init);
> -
> -static void sprd_pinctrl_exit(void)
> -{
> -       platform_driver_unregister(&sprd_pinctrl_driver);
> -}
> -module_exit(sprd_pinctrl_exit);
> +module_platform_driver(sprd_pinctrl_driver);
>
>  MODULE_DESCRIPTION("SPREADTRUM Pin Controller Driver");
>  MODULE_AUTHOR("Baolin Wang <baolin.wang@spreadtrum.com>");
> --
> 2.25.1
>