Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1996628pxk; Mon, 14 Sep 2020 01:44:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvv3xFdZGgzBsb55d/PqwfgdPEGU+GluHW/62NnbEqRWuUpFVjtqqC09nMaAJc3cuUwHfi X-Received: by 2002:a17:906:b04a:: with SMTP id bj10mr13542768ejb.303.1600073084001; Mon, 14 Sep 2020 01:44:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600073083; cv=none; d=google.com; s=arc-20160816; b=VLkOLU1ltczAg9tyq6iHUDCIFs93n5DqRowJCvgVxcd9rE5m2Lg++FWmIopxKSkDc4 i/DxTWrQtqxuorb5K5Gd1fEqjSTs3ic6dWSejeUbmJv8D9/cboSAaZBeHQcED9T7t+gA MEutG3ZbEMbQnIF2Ak16tYBASdFc4glusWwpNki+pvVKwweYJ7XleVuT28GK1Fj747gF E49nBF9Ftd6QjbsgeJwn2TbgX38I+xJdhJwIB2U8DyQ5GEq5BgwwIlTSnA6aIHK/EqNz EXLF8gV20OHqDH3CJ8tn15TNBqvEndkjrxFWPbTvp4lvxmFD0GTy+dWFIZ//Xvx/LGCO bT6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=LWgU1jZ8PSvSLkKeOUXjaR7nKa6gytTYv2DNxld+poE=; b=n2/UJFpbF6SRpf3dylZCoBVS+Lqv2RgM3V8uQTXXoS5u5fbCZly/L3BKSvfSc9fd1V mk90SlL6MIJJO1UxLA8zw9uoSyootFQ3nqth1aX7A9xfTQr6OXpYdHNoYU16w0DCffAL 8RRUCLoffyGShgp6Yo35OwGY4+m9JQiiiJZtf37ANNCetnSylfrWAIHrOrSAWHixkjSA V9KRkyPcu5bDdmEs/9wuFUNgNniNLuAP2WFtUSN8qOr9Thoj/zJukZknhzPXpVxgvHCB 1qERfu8MyucJmKMf+OAFWeftAmmk4l3MyN3EzZLDfYqQMK2Uf/HzH1yWjl1HBLetRD5E E+uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o17si6935621ejg.470.2020.09.14.01.44.20; Mon, 14 Sep 2020 01:44:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgINIlH (ORCPT + 99 others); Mon, 14 Sep 2020 04:41:07 -0400 Received: from smtpout1.mo804.mail-out.ovh.net ([79.137.123.220]:38705 "EHLO smtpout1.mo804.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726183AbgINIlH (ORCPT ); Mon, 14 Sep 2020 04:41:07 -0400 X-Greylist: delayed 316 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Sep 2020 04:41:06 EDT Received: from mxplan5.mail.ovh.net (unknown [10.109.143.134]) by mo804.mail-out.ovh.net (Postfix) with ESMTPS id 68299614D66C; Mon, 14 Sep 2020 10:35:49 +0200 (CEST) Received: from kaod.org (37.59.142.101) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Mon, 14 Sep 2020 10:35:47 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-101G00438ece552-2604-404d-8aff-070da96458dd, 33559CD024D4F69900824C14C2AC4808F9346AFD) smtp.auth=groug@kaod.org Date: Mon, 14 Sep 2020 10:35:46 +0200 From: Greg Kurz To: Jianyong Wu CC: , , , , , , Christian Schoenebeck Subject: Re: [V9fs-developer] [PATCH RFC 0/4] 9p: fix open-unlink-f*syscall bug Message-ID: <20200914103546.0f775bcd@bahia.lan> In-Reply-To: <20200914033754.29188-1-jianyong.wu@arm.com> References: <20200914033754.29188-1-jianyong.wu@arm.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.101] X-ClientProxiedBy: DAG9EX2.mxp5.local (172.16.2.82) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: a4adab61-5db0-417d-bdd6-ca742aabf020 X-Ovh-Tracer-Id: 3126905517296294252 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduiedrudeiiedgtdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeertdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeefuddtieejjeevheekieeltefgleetkeetheettdeifeffvefhffelffdtfeeljeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddruddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepghhrohhugheskhgrohgurdhorhhgpdhrtghpthhtohepqhgvmhhupghoshhssegtrhhuuggvsgihthgvrdgtohhm Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Sep 2020 11:37:50 +0800 Jianyong Wu wrote: > open-unlink-f*syscall bug is a well-known bug in 9p, we try to fix the bug > in this patch set. > I take Eric's and Greg's patches which constiute the 1/4 - 3/4 of this patch > set as the main frame of the solution. In patch 4/4, I fix the fid race issue > exists in Greg's patch. > IIRC some patches were needed on the QEMU side as well... I'm spending less time on 9pfs in QEMU, so Cc'ing the new maintainer: Christian Schoenebeck > Eric Van Hensbergen (1): > fs/9p: fix create-unlink-getattr idiom > > Greg Kurz (1): > fs/9p: search open fids first > > Jianyong Wu (2): > fs/9p: track open fids > 9p: fix race issue in fid contention. > > fs/9p/fid.c | 72 +++++++++++++++++++++++++++++++++++------ > fs/9p/fid.h | 25 +++++++++++--- > fs/9p/vfs_dentry.c | 2 +- > fs/9p/vfs_dir.c | 20 ++++++++++-- > fs/9p/vfs_file.c | 3 +- > fs/9p/vfs_inode.c | 52 +++++++++++++++++++++-------- > fs/9p/vfs_inode_dotl.c | 44 ++++++++++++++++--------- > fs/9p/vfs_super.c | 7 ++-- > fs/9p/xattr.c | 18 ++++++++--- > include/net/9p/client.h | 8 +++++ > net/9p/client.c | 7 +++- > 11 files changed, 206 insertions(+), 52 deletions(-) >