Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: AW: AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer
 size (instead of hardcoding macro name)
To:     Walter Harms <wharms@bfs.de>,
        "mtk.manpages@gmail.com" <mtk.manpages@gmail.com>
Cc:     "linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20200910211344.3562-1-colomar.6.4.3@gmail.com>
 <20200910211344.3562-13-colomar.6.4.3@gmail.com>
 <00ae0174f35241efa962286b9247c590@bfs.de>
 <c2b43a9c-ae80-fae6-16a4-09c9aab73ac1@gmail.com>
 <67f68125677e4e17aa1742b88267e05f@bfs.de>
From:   Alejandro Colomar <colomar.6.4.3@gmail.com>
Message-ID: <fe9ea5de-d09e-2013-22ee-3fff8f3f1c0e@gmail.com>
Date:   Mon, 14 Sep 2020 11:51:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <67f68125677e4e17aa1742b88267e05f@bfs.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Walter,

On 9/14/20 11:24 AM, Walter Harms wrote:
> missunderstanding,
> i do not want to discuss sizeof() vs define

I did understand, that was point (3).

> 
> in this example you do:
> #define BUFLEN 4096
>  char buf[BUFLEN];
> getgrent_r(&grp, buf, sizeof(buf), &grpp);
> 
> so there is no real need for BUFLEN anymore
> so donig
>  char buf[BUFLEN]; -> char buf[4096];
> would remove BUFLEN
> 


However, I think that might be better as a separate patch.

I really don't have many arguments for nor against it.

Thanks,

Alex