Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] MIPS: Remove unused BOOT_MEM_INIT_RAM
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
References: <1599875955-9207-1-git-send-email-tangyouling@loongson.cn>
 <f2349dc3-8086-64ee-e2d7-7a69afac6623@flygoat.com>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Youling Tang <tangyouling@loongson.cn>
Message-ID: <06109011-21af-ad1d-41cb-18542b9b77f6@loongson.cn>
Date:   Mon, 14 Sep 2020 18:39:51 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <f2349dc3-8086-64ee-e2d7-7a69afac6623@flygoat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 09/14/2020 12:32 PM, Jiaxun Yang wrote:
>
>
> 在 2020/9/12 9:59, Youling Tang 写道:
>> Commit a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") left
>> the BOOT_MEM_INIT_RAM unused, remove it.
>>
>> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
>> ---
>>   arch/mips/include/asm/bootinfo.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/mips/include/asm/bootinfo.h 
>> b/arch/mips/include/asm/bootinfo.h
>> index 147c932..39196ae 100644
>> --- a/arch/mips/include/asm/bootinfo.h
>> +++ b/arch/mips/include/asm/bootinfo.h
>> @@ -91,7 +91,6 @@ extern unsigned long mips_machtype;
>>   #define BOOT_MEM_RAM        1
>>   #define BOOT_MEM_ROM_DATA    2
>>   #define BOOT_MEM_RESERVED    3
>> -#define BOOT_MEM_INIT_RAM    4
>
> If you're willing to remove that you'd better turn the memtype struct
> into a enum.
>
Hi  Jiaxun,
Do you mean to modify it as follows?

enum boot_memtype {
                 BOOT_MEM_RAM,
                 BOOT_MEM_ROM_DATA,
                 BOOT_MEM_RESERVED,
                 BOOT_MEM_NOMAP,
};

Thanks.

- Youling
> Btw: It seems you've done a lot of minor clean-up works recently,
> if you'd like to I think you can try to turn all the platforms into 
> memblock
> and remove all these gules between memblock and legacy code.
>
> Thanks.
>
> - Jiaxun
>
>>   #define BOOT_MEM_NOMAP        5
>>     extern void add_memory_region(phys_addr_t start, phys_addr_t 
>> size, long type);