Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2148284pxk; Mon, 14 Sep 2020 06:07:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcUVqNl8ob02Ls9iv/pI2D4Sd7MBVTjQxbpasE9z7QOb2EPvOKyPHb9+0Aab2G6oa5NRcK X-Received: by 2002:a17:906:43c9:: with SMTP id j9mr14305502ejn.542.1600088825122; Mon, 14 Sep 2020 06:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600088825; cv=none; d=google.com; s=arc-20160816; b=tWXaTXBG0+qEJ0OuCl0K8NFVO8jdNeODRrcvBZhdf4s5uMrtVo7UQEHYG6gs9WPHYo krOZjmxbW4UFJmPrj98VL/j/dnfmElH7turR3mbF6PC6xYqNkHN2w38pHGyGDBCEaqTP ilYB7oSBZ0NoM4V+bKqYjMROWuSmyl1LpKr2fpF05xODLQE2O3ZcicClkgUWuznDSR2O 7LF9ui4vGf4EKifOFeLS9UvIcHswe44Ce05yzfCLVoAcytVCHSu2SM8m8w4bP+UfC+2T P+8ObgOoXxxBfvtUSGM+rE2vWJjOsAXAeTnQilMDAmEWq24k37dv0uaRgkbFidW+mZF4 SU8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=R2A8r5GLObxhzjWZElLrw2Vj7QH9pWDZ4/EDMY5I5pM=; b=SFYMoX9DwIgQpNXAK80OT+hryjeblVi0ImYjcmkpYVPtPFg5z+ym5MohxhKDTAEiPv wXs+kuDSuliu6OT5JuZADSBorBGXomSRtBmRhG81UhvoVLrMnuQOlCGcv3U6SiZw3b+F F6Mj4ChbZ537Bu/vKTYdMxFXS7/B5YtMj0fqlICyFUmZ5AVBQIk46XlwDnBFvckxfbaA 1TA/w5cNgr1FUGQ1bvS5Sh+ValPeeI4tM4av1zr1SXEdg9IHSiTSgAOfXvPY7uLjFiPt p5rvzg0hVkKTXiDYNjrJL8qJo3yTPPwh8BVfROJS2eWAv+Cd2J6+9klL32/wiYOzYj5q 9enQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l15si6983646edr.581.2020.09.14.06.06.42; Mon, 14 Sep 2020 06:07:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbgINND1 (ORCPT + 99 others); Mon, 14 Sep 2020 09:03:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:46294 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726297AbgINMdt (ORCPT ); Mon, 14 Sep 2020 08:33:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 26374AC83; Mon, 14 Sep 2020 12:13:22 +0000 (UTC) Date: Mon, 14 Sep 2020 14:13:04 +0200 From: Joerg Roedel To: Vitaly Kuznetsov Cc: Joerg Roedel , Sean Christopherson , Wanpeng Li , Jim Mattson , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , Borislav Petkov , Paolo Bonzini , Colin King Subject: Re: [PATCH -tip] KVM: SVM: nested: Initialize on-stack pointers in svm_set_nested_state() Message-ID: <20200914121304.GC4414@suse.de> References: <20200914115129.10352-1-joro@8bytes.org> <87ft7klg38.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ft7klg38.fsf@vitty.brq.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vitaly, On Mon, Sep 14, 2020 at 02:04:27PM +0200, Vitaly Kuznetsov wrote: > this was previously reported by Colin: > https://lore.kernel.org/kvm/20200911110730.24238-1-colin.king@canonical.com/ > > the fix itself looks good, however, I had an alternative suggestion on how > to fix this: > https://lore.kernel.org/kvm/87o8mclei1.fsf@vitty.brq.redhat.com/ This looks good to me, mind sending your diff as a patch with correct Fixes tag? Thanks, Joerg