Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965054AbWEaPMZ (ORCPT ); Wed, 31 May 2006 11:12:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965057AbWEaPMY (ORCPT ); Wed, 31 May 2006 11:12:24 -0400 Received: from xenotime.net ([66.160.160.81]:52712 "HELO xenotime.net") by vger.kernel.org with SMTP id S965054AbWEaPMY (ORCPT ); Wed, 31 May 2006 11:12:24 -0400 Date: Wed, 31 May 2006 08:15:03 -0700 From: "Randy.Dunlap" To: Anssi Hannula Cc: dtor_core@ameritech.net, linux-joystick@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org Subject: Re: [patch 12/12] input: use -ENOSPC instead of -ENOMEM in iforce when device full Message-Id: <20060531081503.ae9bf422.rdunlap@xenotime.net> In-Reply-To: <447D6A28.4060909@gmail.com> References: <20060530105705.157014000@gmail.com> <20060530110137.412646000@gmail.com> <20060530220205.103536b1.rdunlap@xenotime.net> <447D6A28.4060909@gmail.com> Organization: YPO4 X-Mailer: Sylpheed version 2.2.5 (GTK+ 2.8.3; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2887 Lines: 86 On Wed, 31 May 2006 13:04:24 +0300 Anssi Hannula wrote: > Randy.Dunlap wrote: > > On Tue, 30 May 2006 13:57:17 +0300 Anssi Hannula wrote: > > > > > >>Use -ENOSPC instead of -ENOMEM when the iforce device doesn't have enough free > >>memory for the new effect. All other drivers are already been using -ENOSPC, > >>so this makes the behaviour coherent. > > > > > > Could all of the others be wrong? > > > > They could. > > > ENOSPC: No space left on device > > ENOMEM: Not enough space [!?!?!?] or Out of memory > > > > Hmm, I thought -ENOMEM is "Out of memory" and only to be used when the > system is out of memory, not some internal memory chip in external device. Oh, in the case of a device vs. system, I do agree/prefer ENOSPC. Sorry about my confusion on that. > Does someone have an idea which one should be used? > > > > >>Signed-off-by: Anssi Hannula > >> > >>--- > >> drivers/input/joystick/iforce/iforce-ff.c | 8 ++++---- > >> 1 files changed, 4 insertions(+), 4 deletions(-) > >> > >>Index: linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-ff.c > >>=================================================================== > >>--- linux-2.6.17-rc4-git12.orig/drivers/input/joystick/iforce/iforce-ff.c 2006-05-26 16:55:12.000000000 +0300 > >>+++ linux-2.6.17-rc4-git12/drivers/input/joystick/iforce/iforce-ff.c 2006-05-26 16:57:13.000000000 +0300 > >>@@ -47,7 +47,7 @@ static int make_magnitude_modifier(struc > >> iforce->device_memory.start, iforce->device_memory.end, 2L, > >> NULL, NULL)) { > >> mutex_unlock(&iforce->mem_mutex); > >>- return -ENOMEM; > >>+ return -ENOSPC; > >> } > >> mutex_unlock(&iforce->mem_mutex); > >> } > >>@@ -80,7 +80,7 @@ static int make_period_modifier(struct i > >> iforce->device_memory.start, iforce->device_memory.end, 2L, > >> NULL, NULL)) { > >> mutex_unlock(&iforce->mem_mutex); > >>- return -ENOMEM; > >>+ return -ENOSPC; > >> } > >> mutex_unlock(&iforce->mem_mutex); > >> } > >>@@ -120,7 +120,7 @@ static int make_envelope_modifier(struct > >> iforce->device_memory.start, iforce->device_memory.end, 2L, > >> NULL, NULL)) { > >> mutex_unlock(&iforce->mem_mutex); > >>- return -ENOMEM; > >>+ return -ENOSPC; > >> } > >> mutex_unlock(&iforce->mem_mutex); > >> } > >>@@ -157,7 +157,7 @@ static int make_condition_modifier(struc > >> iforce->device_memory.start, iforce->device_memory.end, 2L, > >> NULL, NULL)) { > >> mutex_unlock(&iforce->mem_mutex); > >>- return -ENOMEM; > >>+ return -ENOSPC; > >> } > >> mutex_unlock(&iforce->mem_mutex); > >> } > >> > >>-- --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/