Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965069AbWEaPtt (ORCPT ); Wed, 31 May 2006 11:49:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965070AbWEaPtt (ORCPT ); Wed, 31 May 2006 11:49:49 -0400 Received: from mail7.sea5.speakeasy.net ([69.17.117.9]:17332 "EHLO mail7.sea5.speakeasy.net") by vger.kernel.org with ESMTP id S965069AbWEaPts (ORCPT ); Wed, 31 May 2006 11:49:48 -0400 Date: Wed, 31 May 2006 11:49:44 -0400 (EDT) From: James Morris X-X-Sender: jmorris@d.namei To: Stephen Smalley cc: Arjan van de Ven , Michal Piotrowski , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [patch 1/1] selinux: fix sb_lock/sb_security_lock nesting (Was: Re: 2.6.17-rc5-mm1) In-Reply-To: <1149087412.524.169.camel@moss-spartans.epoch.ncsc.mil> Message-ID: References: <20060530022925.8a67b613.akpm@osdl.org> <6bffcb0e0605301139l2b4895d0mbecffb422fb2c0cf@mail.gmail.com> <1149015890.3636.92.camel@laptopd505.fenrus.org> <1149087412.524.169.camel@moss-spartans.epoch.ncsc.mil> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 680 Lines: 19 On Wed, 31 May 2006, Stephen Smalley wrote: > Yes, looks that way, although oddly I don't see this warning myself upon > performing a umount (w/ 2.6.17-rc5-mm1-lockdep). Patch below should > fix. > > --- > > Fix unsafe nesting of sb_lock inside sb_security_lock in selinux_complete_init. > Detected by the kernel locking validator. > > Signed-off-by: Stephen Smalley Acked-by: James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/