Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Zhang Changzhong <zhangchangzhong@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next] net: fec: ptp: remove unused variable 'ns' in
 fec_time_keep()
Thread-Topic: [PATCH net-next] net: fec: ptp: remove unused variable 'ns' in
 fec_time_keep()
Thread-Index: AQHWipki3XCTRnqQD0iUbmkKhFWiuqloMy5A
Date:   Mon, 14 Sep 2020 14:35:38 +0000
Message-ID: <AM8PR04MB7315343612D0F76F6D6EB8CAFF230@AM8PR04MB7315.eurprd04.prod.outlook.com>
References: <1600089264-21910-1-git-send-email-zhangchangzhong@huawei.com>
In-Reply-To: <1600089264-21910-1-git-send-email-zhangchangzhong@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c6d7bd9f-3a87-416e-04e9-08d858bb72f1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2020 14:35:38.3013
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cbNqqI2cuoa03T1Pl6zOTUPRujG7Rqr4qDIPiSLu/fFBWqMjrEMJDwwNmguQWG+j5KHDsXE4BwzW3TaKztW+KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3476
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Zhang Changzhong <zhangchangzhong@huawei.com> Sent: Monday, September=
 14, 2020 9:14 PM
> Fixes the following W=3D1 kernel build warning(s):
>=20
> drivers/net/ethernet/freescale/fec_ptp.c:523:6: warning:
>  variable 'ns' set but not used [-Wunused-but-set-variable]
>   523 |  u64 ns;
>       |      ^~
>=20
> After commit 6605b730c061 ("FEC: Add time stamping code and a PTP
> hardware clock"), variable 'ns' is never used in fec_time_keep(), so remo=
ving it
> to avoid build warning.
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>

Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  drivers/net/ethernet/freescale/fec_ptp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index a0c1f44..0405a39 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -520,13 +520,12 @@ static void fec_time_keep(struct work_struct *work)
> {
>  	struct delayed_work *dwork =3D to_delayed_work(work);
>  	struct fec_enet_private *fep =3D container_of(dwork, struct
> fec_enet_private, time_keep);
> -	u64 ns;
>  	unsigned long flags;
>=20
>  	mutex_lock(&fep->ptp_clk_mutex);
>  	if (fep->ptp_clk_on) {
>  		spin_lock_irqsave(&fep->tmreg_lock, flags);
> -		ns =3D timecounter_read(&fep->tc);
> +		timecounter_read(&fep->tc);
>  		spin_unlock_irqrestore(&fep->tmreg_lock, flags);
>  	}
>  	mutex_unlock(&fep->ptp_clk_mutex);
> --
> 2.9.5