Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2283001pxk; Mon, 14 Sep 2020 09:11:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyeEqg64yJI/asztaGL8EXn+tGSFDYGce1XY/9vYJlsm1frMW00xUDIPe5/1Ub4DgnriXb/ X-Received: by 2002:a50:8c24:: with SMTP id p33mr18088761edp.330.1600099896319; Mon, 14 Sep 2020 09:11:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600099896; cv=none; d=google.com; s=arc-20160816; b=jsl9BTXPX3Ms7rbTojnb5bUtegPtRt4OyvGtwXfT0AMhptc4HlwPMnAbpeH/neSZC2 f8VjMXLsf51afEjLfJOY8xnGiW0mu6sNOKS0FPZkoWFAw4avHUllL5kfZNW3L6PrCjAW LxZ9cLCBLB/V5njexOU+TGds+BVA85Wu/jNV4b3LGoAFAfQzR+kroVGjDUnAHgFJQABD sHwt9NFcNEf211PzRe4Y4rm4PO6ss784NU/Bh3bY6vV+maoF0aCA0QklWsWMeQ3tH7Tg LJ7eMK6q1jEUG7+4vA6NXJMinydjKIA3JV6PQHpdsar6U7Fyq8WvdvzRDcOiOnZgM+rQ eiUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=skufs++e/7ON+fn91yOjCzDoKAPQf7Kzb5NWuKcjwVI=; b=MfpwVm86DvSou9thgFZyQaK275bYBid3FbzlbBGYylUXPG1OKOuGMZ0kYlog+xtDN2 qY79a7hsKahsM7P0keh6qDkUpaRUxghHWDqDrkEHFOJRAABIKRtIS+J4NqigK6C3CqXY 7EX+RKLdKBiuLDs/a/jGIuFQ8rsdRNgJwC37VB8yr0tCgoef+UpGAd2PNaWNxwrNRWZI SCvdbrS3jG47R007/vBmr3OI5S5edtZBQdSA7Zhv/4qUKDNA+JPUq4rLAqb3q+pUKo0k ClYZFatwfBBRfehRIww0/aPp+cwpX0ZCpK/6duMAs6l5gYHcLmBS5O9TsCKiL+ctnntU NPeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl4si8161295ejb.512.2020.09.14.09.11.14; Mon, 14 Sep 2020 09:11:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726478AbgINQKQ (ORCPT + 99 others); Mon, 14 Sep 2020 12:10:16 -0400 Received: from mga01.intel.com ([192.55.52.88]:20121 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbgINQHQ (ORCPT ); Mon, 14 Sep 2020 12:07:16 -0400 IronPort-SDR: Q95QUSTE79/pFCwBScfYGYrVMaY3/mlLbcxl+E6wE8B3F/k4P14GpEiRn+fzPJgtec3IXRTj/5 w+0Q+4P6idSw== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="177163241" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="177163241" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 09:06:41 -0700 IronPort-SDR: QSuTLZPYyEx/9A4qq6SZEnLbfXsDH2Pdk9RcBl+P4oAtC0CPqqKrHLwbet1Df3Vp1mqEj+9ZMD kN0OORP71wCQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="335327535" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 14 Sep 2020 09:06:38 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kHqzy-00Gda8-Gs; Mon, 14 Sep 2020 19:06:34 +0300 Date: Mon, 14 Sep 2020 19:06:34 +0300 From: Andy Shevchenko To: Hsin-Yi Wang Cc: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , Serge Semin , Changqi Hu , Frank Wunderlich , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Enric Balletbo i Serra Subject: Re: [PATCH 1/2] tty: serial: print earlycon info after match->setup Message-ID: <20200914160634.GL3956970@smile.fi.intel.com> References: <20200911093927.608024-1-hsinyi@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911093927.608024-1-hsinyi@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2020 at 05:39:26PM +0800, Hsin-Yi Wang wrote: > 8250 devices may modify iotype in their own earlycon setup. For example: > 8250_mtk and 8250_uniphier force iotype to be MMIO32. Print earlycon info > after match->setup to reflect actual earlycon info. But this means you do something which user didn't ask for... > +static void __init earlycon_info(struct earlycon_device *device) Can it be earlycon_pr_info() or earlycon_print_info() ? -- With Best Regards, Andy Shevchenko