Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2306540pxk; Mon, 14 Sep 2020 09:45:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy0/uGlMyc2Km9VuPhv1m+PbyQPJbLh8zJsKLplVMfRmuBkEtw0tAiofXeiGYRB5O1MrdWe X-Received: by 2002:a17:906:4805:: with SMTP id w5mr8455746ejq.313.1600101956887; Mon, 14 Sep 2020 09:45:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600101956; cv=none; d=google.com; s=arc-20160816; b=QGpcN6V0TkMgc7j3R3v/Wo7zOkAPjTd9B9AcV94QmMMULL8aVpo2IBkVSwmfH3HDgr HJ7KRNqTV3CZSrV+Th80ilm2/Nqx7ESeChe9qQ4DSpRpgJvWVWzXJDBLyeesO0Cx0vvI OGDCPGEuBPjJe6Ty495aIS+jjumTvRIwFpyxUbCLlv2yLIk/hIMOMaaY/AwoDJ7cqWf2 C+MNHW1iaHKc+h+cyTV/eTL99+8Ez4fCQtRTCCHY3CpYLeMSbc1AdcKkIGhB3man8QFk crfPnaVWDfhnt3codlnLFvchzv62SiTegYcsUVOMoFP5XSe6Swwbvtz1jGo9mTHx4hHk 0HPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=2n6xn1dNb+jBWIYWoXM59/cL0r2SN9OLGc/w/yYX4lc=; b=lzt/YXC1NtzQBoPIl+6ifR9iJtRY4kfIuO/Jnt7kUkx1bQY3NLX/nTeeGpZ+CC7yFx 8XL4ba82XW3sFH7FAlxRHGxXxwzW1lPJIX1FC/dThDp3B7rqtDTE1tApexcUjPIAwWcg 4XoFNG7q+TAn6NgKQ+0LNwnd8juIKGJkfK3jjZ3PlVOLA8HXuI+nStJQOIHLGfFtYto0 ddvwjJaVaYd7YkDqzSOh4ktvd+9Mh0/AemD/JTeev2YnGPd68/n4l0RizABRz9EqHd9D tGxz7NX7eNWfkl3DHLmuiUfvhHSmTVAP7dnoRUCHixF9NOGNX4xrfK1vzkNFwa4jJyMT vCgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CX21HqYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si8012046edy.478.2020.09.14.09.45.33; Mon, 14 Sep 2020 09:45:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CX21HqYO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbgINQmi (ORCPT + 99 others); Mon, 14 Sep 2020 12:42:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:32778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbgINPNN (ORCPT ); Mon, 14 Sep 2020 11:13:13 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39BDB20829; Mon, 14 Sep 2020 15:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600096393; bh=2n6xn1dNb+jBWIYWoXM59/cL0r2SN9OLGc/w/yYX4lc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CX21HqYOSTW7DxJJi9tuQNthrvklblenjRZ8AKtZedFGn5cnOcyTnun31WvqoZvUu vt/mlbJvtmTMtGM+Rx2kQUQeVHlUaFraOTtA7nKxTyzGlBe6INrZLXSaayWu4LpVSr Q1/eyCA5lY3hFIeaFqEteERMOwqykEL70biA9hwA= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1370440D3D; Mon, 14 Sep 2020 12:13:11 -0300 (-03) Date: Mon, 14 Sep 2020 12:13:10 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , Alexei Starovoitov , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Michael Petlan , Song Liu , "Frank Ch. Eigler" , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Subject: Re: [RFC 00/26] perf: Add mmap3 support Message-ID: <20200914151310.GA160517@kernel.org> References: <20200913210313.1985612-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Sep 14, 2020 at 02:25:25PM +0900, Namhyung Kim escreveu: > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > while playing with perf daemon support I realized I need > > the build id data in mmap events, so we don't need to care > > about removed/updated binaries during long perf runs. > > This RFC patchset adds new mmap3 events that copies mmap2 > > event and adds build id in it. It makes mmap3 the default > > mmap event for synthesizing kernel/modules/tasks and adds > > some tooling enhancements to enable the workflow below. > Cool! It's nice that we can skip the final build-id collection stage > with this while data size will be bigger. Yeah, this is something long overdue, comes with extra cost for people not wanting build-ids, but then they can just use MMAP2 or even MMAP if that is enough. More comments on the other patches. - Arnaldo