Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Sep 2020 09:47:26 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Omer Shpigelman <oshpigelman@habana.ai>
Cc:     Oded Gabbay <oded.gabbay@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        SW_Drivers <SW_Drivers@habana.ai>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH 05/15] habanalabs/gaudi: add NIC Ethernet support
Message-ID: <20200914094726.1c5f747c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <AM0PR02MB5523D7FD712C3B50DA733CDDB8230@AM0PR02MB5523.eurprd02.prod.outlook.com>
References: <20200910161126.30948-1-oded.gabbay@gmail.com>
        <20200910161126.30948-6-oded.gabbay@gmail.com>
        <20200910130307.5dee086b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <AM0PR02MB5523D7FD712C3B50DA733CDDB8230@AM0PR02MB5523.eurprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 14 Sep 2020 09:52:00 +0000 Omer Shpigelman wrote:
> On Thu, Sep 10, 2020 at 11:03 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > On Thu, 10 Sep 2020 19:11:16 +0300 Oded Gabbay wrote:  
> > > +module_param(nic_rx_poll, int, 0444);  
> > MODULE_PARM_DESC(nic_rx_poll,  
> > > +	"Enable NIC Rx polling mode (0 = no, 1 = yes, default no)");  
> > 
> > If your chip does not support IRQ coalescing you can configure polling and the
> > timeout via ethtool -C, rather than a module parameter.  
> 
> I couldn't find an example for that in other drivers and I didn't see
> anything regarding polling mode in the parameters description of this
> ethtool callback.
> Can you please specify some pointer for that? Or in other words, what
> parameter can we use to enable polling/setting the timeout?

Look at stmmac, hip04_eth..