Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp2331824pxk; Mon, 14 Sep 2020 10:25:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn8ndPERYYD7J8O18aDYHbvs7U1WsbFLVLVBI0lX7Q+CqydZnYDsCZftG0XeuAfP1Hiff5 X-Received: by 2002:a50:eb0a:: with SMTP id y10mr3161649edp.89.1600104300930; Mon, 14 Sep 2020 10:25:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1600104300; cv=none; d=google.com; s=arc-20160816; b=hN5RMNjRNEyS1zhWoy22GE3z/OSZg4Q/f6t8+jGd1S1VvLaEQlLSyTLNCDt6lb5zDE LSmsuTvzg8MX/Mx+S/S45UMwom6APdMTMgGbSHzw6B640a2roEn72nhX6DF5wIWgknXY h46FYD+reXqbIE8NqSAa0C8VkmZJF9WHggJ/xL+pBK9wb2SgW37roh+I85c/pWAxK5nd b8RZEB0C0KvlZy21/WonWDf9m6mu+vDa0Ex+ixoHrxQY9yNHdAEDWcPkMT2eNNZvLUZ5 fJxLl3sNjJw9rGoQDZCIA8GdqBa9+2j7ADUisMVn0eefhoY6qRWjh+XY6WfXsL3eOhHR VdUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=fk8zzz6iG+LTm12PI7VouoO/Ytz2Ct1GiEhjBUFwErY=; b=hnM+EZJy7SSGdaIgR4oEIFSM0NNXIKdRt4XUe/SZvO7cJ8YI+oaDHs1HzJxVha9F4W hyptbilG9VqURVtilkziIYZktqrW3JuCqwzW7SxBFoIxirZe5iXjN7muuwtKoSgP3KpS jEfmNyYZjXJePReYGXDjUtmxgRgZpLzcT5lKJGpmU3hbIpgJeVqdO0kS2K030RR0IzJe cuO8Vpuycz27B7JXIrfJjHMCt5voUXCwsxYt4t8GSPsxvvROgoILj2LmlnWvjpN3nYn7 fEaECMT3G6nUjHxU8xB8N4qYflvJXY1igbGpep7QsYP9k8f+JomqKoCwYpV0QDdUP4wT LjmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AYYeMzNY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gr23si5408833ejb.586.2020.09.14.10.24.38; Mon, 14 Sep 2020 10:25:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AYYeMzNY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726349AbgINRXY (ORCPT + 99 others); Mon, 14 Sep 2020 13:23:24 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:37183 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726350AbgINM3b (ORCPT ); Mon, 14 Sep 2020 08:29:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600086568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fk8zzz6iG+LTm12PI7VouoO/Ytz2Ct1GiEhjBUFwErY=; b=AYYeMzNY5Bspq0LrGLneAO6ZMmdhtwSohYvLC711L0IHDj22DvEvdmDeGLFKh5i4CDm8o1 NfBW/1DNeo3FazUgxSIfGjjh7kT+2yOILd8QsqH+uMz2wfgGm5ezLdBAC0JZb+sQ93KRzW e8To/wK3rpQBOCACv4lr53ZeCuQ9I4w= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-YoJ2SHaYObak6LW2DYdg2A-1; Mon, 14 Sep 2020 08:29:27 -0400 X-MC-Unique: YoJ2SHaYObak6LW2DYdg2A-1 Received: by mail-wr1-f69.google.com with SMTP id n15so6813804wrv.23 for ; Mon, 14 Sep 2020 05:29:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fk8zzz6iG+LTm12PI7VouoO/Ytz2Ct1GiEhjBUFwErY=; b=gl9dmKELclilX4drHooOCcAVNlmVqVXwtnJTj6nolQFUNBl2qEASnnvfyPjyfU14fD HbaTF8mar16NtaKvv3RrXa5l8twiEQ02HbSUXp87zPZkPRMIOoKbJDpdmcb2KLt6RQAs jUGTlIqTYS+F17oSbrMzuiJE3ZgGP9IpqENK63sT9fiCvdEfLI6WfslQ6rDJSmZHIiL3 gjuVf1viSFdbF8uO0/jYhtgi8R+uLMZsbGjdejcqoxuyFQ7moJ3MOcbsf4gnbH9wXpsz GtsKzW6CoXB4z5r1RhAsruqeXoX+HmwSyYLc4FTWXLZpKUfVrWZmDzlWNUkeg7fekJdl H6jg== X-Gm-Message-State: AOAM530GuOLN4lZvTgs0nIsZjeyqXivXBf24fYhXsK3W8rv/MbiTtSjS WY0N3KvPD7LWs8QEOOHJm1H5wfgebg+1bxTkCAl4xVHHltBJaXkiW8xk/NORQyFgJ5I4RGXsRIQ 0oIJNuH3zj1MW0AF+oZXon1SJi+AArd8IQL/vbAbS X-Received: by 2002:adf:e391:: with SMTP id e17mr15196098wrm.289.1600086566095; Mon, 14 Sep 2020 05:29:26 -0700 (PDT) X-Received: by 2002:adf:e391:: with SMTP id e17mr15196076wrm.289.1600086565833; Mon, 14 Sep 2020 05:29:25 -0700 (PDT) MIME-Version: 1.0 References: <20200623052059.1893966-1-david@fromorbit.com> <20200914113516.GE4863@quack2.suse.cz> In-Reply-To: <20200914113516.GE4863@quack2.suse.cz> From: Andreas Gruenbacher Date: Mon, 14 Sep 2020 14:29:14 +0200 Message-ID: Subject: Re: More filesystem need this fix (xfs: use MMAPLOCK around filemap_map_pages()) To: Dave Chinner , linux-xfs Cc: Jan Kara , Amir Goldstein , Theodore Tso , Martin Brandenburg , Mike Marshall , Damien Le Moal , Jaegeuk Kim , Qiuyang Sun , linux-fsdevel , Linux MM , linux-kernel , Matthew Wilcox , Linus Torvalds , "Kirill A. Shutemov" , Andrew Morton , Al Viro Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Could the xfs mmap lock documentation please be cleaned up? For example, the xfs_ilock description says: > * In addition to i_rwsem in the VFS inode, the xfs inode contains 2 > * multi-reader locks: i_mmap_lock and the i_lock. This routine allows > * various combinations of the locks to be obtained. The field in struct xfs_inode is called i_mmaplock though, not i_mmap_lock. In addition, struct inode has an i_mmap_rwsem field which is also referred to as i_mmap_lock. If that isn't irritating enough. Thanks, Andreas