Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Viorel Suman (OSS)" <viorel.suman@oss.nxp.com>
To:     Timur Tabi <timur@kernel.org>,
        Nicolin Chen <nicoleotsuka@gmail.com>,
        Xiubo Li <Xiubo.Lee@gmail.com>,
        Fabio Estevam <festevam@gmail.com>,
        Shengjiu Wang <shengjiu.wang@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     NXP Linux Team <linux-imx@nxp.com>,
        Viorel Suman <viorel.suman@gmail.com>,
        Viorel Suman <viorel.suman@nxp.com>
Subject: [PATCH] ASoC: fsl_audmix: make clock and output src write only
Date:   Mon, 14 Sep 2020 20:24:34 +0300
Message-Id: <1600104274-13110-1-git-send-email-viorel.suman@oss.nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from fsr-ub1664-116.ea.freescale.net (83.217.231.2) by AM0PR10CA0044.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:150::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3370.19 via Frontend Transport; Mon, 14 Sep 2020 17:24:40 +0000
X-Mailer: git-send-email 2.7.4
X-Originating-IP: [83.217.231.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: ea276ba8-48ee-4204-de84-08d858d31084
X-MS-TrafficTypeDiagnostic: VI1PR04MB6047:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB6047F723D7F357C946BB7EF9D3230@VI1PR04MB6047.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2657;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: nD/3hDgAqby1z4DChfzfbLMIlmziMhJv6L7NXPmZunXuu9ns2QNqcRApdY8mnpi3Vi159hseZ2t1fk8wzHCzGOQ5UcJei9nfQnZGV67JNsW67sslur0UL2A29bqxMW0rjl7ZVKVCjdLklYrjk4wNVZijZ37YAYoOGsSnU1vkMxBhTbWGad2oFlyCtC+pQI/9LnW8ZYC6ert1R/lvcM38HrLbpgtzQfloSuCXPs8hfrlOcb05A4fTr453BZD5b7YEU2upWO2jGIgrIBUY88esSelG0FbVLCBkCK/9VdEl/PRxtRFXa6jsfd4H/2BXH4+nXIFQZw0lx/X00zA412ZMsBQlRSqHKnN24XDDLlSvhHF9I/J3AeXppWYbyyatqRWq
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0401MB2272.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(396003)(366004)(376002)(39860400002)(4326008)(5660300002)(83380400001)(7416002)(16526019)(8676002)(8936002)(6486002)(2906002)(86362001)(2616005)(956004)(6506007)(6666004)(6512007)(316002)(66946007)(110136005)(186003)(26005)(66556008)(52116002)(54906003)(478600001)(66476007)(921003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: Wt9nM+NNaxgeNhlrn4lqd4pDni5UgvOBogBGUyolXnyFYRFW6cdvrO9IkTddavKBWTW2tBtr+Zon9V0XIUZ2uWbbdbamDhC4+x1/eMbs7PacONCrWrD1uW2GcfJHAr0kxWCqtfx8Xs1ZMv+bOBmd6510Q7C14qj0SYOYEU0AsfXRoughCVbGlrz5PkLR6sPFBPdevNaUnQdo77a5aXlU5wNt09H4hlALSKbkqtbIXi+dzyE7DedlyZyLIgPuKKxwALoOTJ+W9ZYWIqBPzUpHkApRVJ2XhlvxzK7+iMTgQvC9agyO613h5t05FYcBa28Bnyuo8H7ewiSdyOl4BD+kIKMN+lS1o7RnixYnGAS4poqqYQXp2/6TJVCCpXWHU/jMpXxi5M9pKaIuDWIgW9CpW+r7tUEv65VTj2aGocu2wzBJTxrKJ5zdQJ/s51PnDIfy0qA+OMBYS0sAyy9klgvuXm43ox8DybqBZI+WtLpjEokBQTmc4c1M9EE+TQLZAuzZin+8kQz/QSJJufQlizQk3zguh9nvJj4KLoYC3ekGvoYlGH9CorSvSahhlPSIzwowuIMODTKtieYPC+Q+SqR/rA80KpCG4CpkQJOQxzxwqu+l+QEIEIYMkE3hTieWktOVK0Me9b+RGUt/MKisda8gWA==
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea276ba8-48ee-4204-de84-08d858d31084
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2272.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2020 17:24:41.4665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: napGHQGam2D8PTh0PEzafiI1NGZo0hcauqp7+usF1CenJ3sTJn/4SaCjNpVNLGD4x55Yk7slby08SVYPFsyMJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6047
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Viorel Suman <viorel.suman@nxp.com>

"alsactl -f state.conf store/restore" sequence fails because setting
"mixing clock source" and "output source" requires active TDM clock
being started for configuration propagation. Make these two controls
write only so that their values are not stored at "alsactl store".

Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
---
 sound/soc/fsl/fsl_audmix.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c
index a447baf..7ad5925 100644
--- a/sound/soc/fsl/fsl_audmix.c
+++ b/sound/soc/fsl/fsl_audmix.c
@@ -199,10 +199,18 @@ static int fsl_audmix_put_out_src(struct snd_kcontrol *kcontrol,
 
 static const struct snd_kcontrol_new fsl_audmix_snd_controls[] = {
 	/* FSL_AUDMIX_CTR controls */
-	SOC_ENUM_EXT("Mixing Clock Source", fsl_audmix_enum[0],
-		     snd_soc_get_enum_double, fsl_audmix_put_mix_clk_src),
-	SOC_ENUM_EXT("Output Source", fsl_audmix_enum[1],
-		     snd_soc_get_enum_double, fsl_audmix_put_out_src),
+	{	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+		.name = "Mixing Clock Source",
+		.info = snd_soc_info_enum_double,
+		.access = SNDRV_CTL_ELEM_ACCESS_WRITE,
+		.put = fsl_audmix_put_mix_clk_src,
+		.private_value = (unsigned long)&fsl_audmix_enum[0] },
+	{	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+		.name = "Output Source",
+		.info = snd_soc_info_enum_double,
+		.access = SNDRV_CTL_ELEM_ACCESS_WRITE,
+		.put = fsl_audmix_put_out_src,
+		.private_value = (unsigned long)&fsl_audmix_enum[1] },
 	SOC_ENUM("Output Width", fsl_audmix_enum[2]),
 	SOC_ENUM("Frame Rate Diff Error", fsl_audmix_enum[3]),
 	SOC_ENUM("Clock Freq Diff Error", fsl_audmix_enum[4]),
-- 
2.7.4