Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Sep 2020 19:06:29 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     mateusznosek0@gmail.com
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        viro@zeniv.linux.org.uk
Subject: Re: [RFC PATCH] fs: micro-optimization remove branches by adjusting
 flag values
Message-ID: <20200914180629.GT6583@casper.infradead.org>
References: <20200914174338.9808-1-mateusznosek0@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200914174338.9808-1-mateusznosek0@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Sep 14, 2020 at 07:43:38PM +0200, mateusznosek0@gmail.com wrote:
> From: Mateusz Nosek <mateusznosek0@gmail.com>
> 
> When flags A and B have equal values than the following code
> 
> if(flags1 & A)
> 	flags2 |= B;
> 
> is equivalent to
> 
> flags2 |= (flags1 & A);
> 
> The latter code should generate less instructions and be faster as one
> branch is omitted in it.

[citation needed]

$ cat test.c 
int a(int x)
{
	int y = 0;

	if (x & 1)
		y |= 1;
	if (x & 2)
		y |= 2;

	return y;
}

$ objdump -d test.o
0000000000000000 <a>:
   0:   89 f8                   mov    %edi,%eax
   2:   83 e0 03                and    $0x3,%eax
   5:   c3                      retq   

Please stop submitting uglifying patches without checking they actually
improve anything.  GCC is smarter than you think it is.