Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200911143022.414783-1-nicolas.rybowski@tessares.net> <20200911143022.414783-5-nicolas.rybowski@tessares.net>
In-Reply-To: <20200911143022.414783-5-nicolas.rybowski@tessares.net>
From:   Song Liu <song@kernel.org>
Date:   Mon, 14 Sep 2020 11:08:50 -0700
Message-ID: <CAPhsuW5j0i0fk+XBun=v15H+-TvKjTF=XUhueuf30Hgp1=dESQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next v2 5/5] bpf: selftests: add bpf_mptcp_sock()
 verifier tests
To:     Nicolas Rybowski <nicolas.rybowski@tessares.net>
Cc:     Shuah Khan <shuah@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        Andrii Nakryiko <andriin@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@chromium.org>,
        Matthieu Baerts <matthieu.baerts@tessares.net>,
        linux-kselftest@vger.kernel.org,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 11, 2020 at 9:46 AM Nicolas Rybowski
<nicolas.rybowski@tessares.net> wrote:
>
> This patch adds verifier side tests for the new bpf_mptcp_sock() helper.
>
> Here are the new tests :
> - NULL bpf_sock is correctly handled
> - We cannot access a field from bpf_mptcp_sock if the latter is NULL
> - We can access a field from bpf_mptcp_sock if the latter is not NULL
> - We cannot modify a field from bpf_mptcp_sock.
>
> Note that "token" is currently the only field in bpf_mptcp_sock.
>
> Currently, there is no easy way to test the token field since we cannot
> get back the mptcp_sock in userspace, this could be a future amelioration.
>
> Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> Signed-off-by: Nicolas Rybowski <nicolas.rybowski@tessares.net>

Acked-by: Song Liu <songliubraving@fb.com>